Changeset 1379 in josm

Timestamp:

2009-02-08T11:34:23+01:00 (15 years ago)

Author:

stoecker

Message:

apply #2127. patch by xeen

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/mapmode/DeleteAction.java (modified) (2 diffs)
• actions/mapmode/DrawAction.java (modified) (2 diffs)
• actions/mapmode/ExtrudeAction.java (modified) (2 diffs)
• actions/mapmode/MapMode.java (modified) (2 diffs)
• actions/mapmode/SelectAction.java (modified) (2 diffs)
• gui/MapView.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/DeleteAction.java

@@ -15 +15 @@
 import org.openstreetmap.josm.data.osm.WaySegment;
 import org.openstreetmap.josm.gui.MapFrame;
+import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Shortcut;
@@ -129 +131 @@
         return tr("Click to delete. Shift: delete way segment. Alt: don't delete unused nodes when deleting a way. Ctrl: delete referring objects.");
     }
+    
+    @Override public boolean layerIsSupported(Layer l) {
+        return l instanceof OsmDataLayer;
+    }
 }

trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -50 +50 @@
 import org.openstreetmap.josm.gui.MapView;
 import org.openstreetmap.josm.gui.layer.MapViewPaintable;
+import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Pair;
@@ -647 +649 @@
         return rv.toString();
     }
+    
+    @Override public boolean layerIsSupported(Layer l) {
+        return l instanceof OsmDataLayer;
+    }
 }

trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

@@ -29 +29 @@
 import org.openstreetmap.josm.gui.MapView;
 import org.openstreetmap.josm.gui.layer.MapViewPaintable;
+import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Shortcut;
@@ -257 +259 @@
         }
     }
+                
+                @Override public boolean layerIsSupported(Layer l) {
+                                return l instanceof OsmDataLayer;
+                }
 }

trunk/src/org/openstreetmap/josm/actions/mapmode/MapMode.java

@@ -10 +10 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.JosmAction;
+import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.tools.ImageProvider;
@@ -71 +72 @@
             Main.map.selectMapMode(this);
     }
+    
+    // By default, all tools will work with all layers. Can be overwritten to require
+    // a special type of layer
+    public boolean layerIsSupported(Layer l) {
+        return true;
+    }
 
     public void mouseReleased(MouseEvent e) {}

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -32 +32 @@
 import org.openstreetmap.josm.data.osm.visitor.AllNodesVisitor;
 import org.openstreetmap.josm.data.osm.visitor.SimplePaintVisitor;
+import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.MapView;
@@ -395 +397 @@
         }
     }
+    
+    @Override public boolean layerIsSupported(Layer l) {
+        return l instanceof OsmDataLayer;
+    }
 }

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -15 +15 @@
 import java.awt.image.BufferedImage;
 import java.util.ArrayList;
+import java.util.Enumeration;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedList;
 
+import javax.swing.AbstractButton;
 import javax.swing.JComponent;
 import javax.swing.JOptionPane;
@@ -25 +27 @@
 import org.openstreetmap.josm.actions.AutoScaleAction;
 import org.openstreetmap.josm.actions.JosmAction;
+import org.openstreetmap.josm.actions.mapmode.MapMode;
 import org.openstreetmap.josm.actions.MoveAction;
 import org.openstreetmap.josm.data.Bounds;
@@ -357 +360 @@
                 l.activeLayerChange(old, layer);
         }
+        
+        /* This only makes the buttons look disabled. Disabling the actions as well requires
+         * the user to re-select the tool after i.e. moving a layer. While testing I found
+         * that I switch layers and actions at the same time and it was annoying to mind the
+         * order. This way it works as visual clue for new users */
+        for (Enumeration e = Main.map.toolGroup.getElements() ; e.hasMoreElements() ;) {
+            AbstractButton x=(AbstractButton)e.nextElement();
+            x.setEnabled(((MapMode)x.getAction()).layerIsSupported(layer));
+        }
         repaint();
     }