Changeset 13689 in josm for trunk/src/org

Timestamp:

2018-04-27T00:42:18+02:00 (6 years ago)

Author:

Don-vip

Message:

see #16189 - do not alter non-orthogonal building shapes

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/RightAngleBuildingTest.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/RightAngleBuildingTest.java

@@ -5 +5 @@
 
 import java.util.Collections;
+import java.util.List;
 
 import org.openstreetmap.josm.actions.OrthogonalizeAction;
@@ -44 +45 @@
         if (!w.isUsable() || !w.isClosed() || !isBuilding(w)) return;
 
-        for (Pair<Double, Node> pair: w.getAngles()) {
-            if (!checkAngle(w, pair.a, pair.b))
+        List<Pair<Double, Node>> angles = w.getAngles();
+        for (Pair<Double, Node> pair: angles) {
+            if (checkAngle(w, pair.a, pair.b)) {
+                TestError.Builder builder = TestError.builder(this, Severity.WARNING, 3701)
+                                                     .message(tr("Building with an almost square angle"))
+                                                     .primitives(w)
+                                                     .highlight(pair.b);
+                if (angles.stream().noneMatch(p -> Math.abs(p.a - 90) >= maxAngleDelta)) {
+                    builder.fix(() -> {
+                        try {
+                            return OrthogonalizeAction.orthogonalize(Collections.singleton(w));
+                        } catch (InvalidUserInputException e) {
+                            Logging.warn(e);
+                            return null;
+                        }
+                    });
+                }
+                errors.add(builder.build());
                 return;
+            }
         }
     }
@@ -59 +77 @@
     private boolean checkAngle(Way w, double angle, Node n) {
         double difference = Math.abs(angle - 90);
-
-        if (difference > minAngleDelta && difference < maxAngleDelta) {
-            errors.add(TestError.builder(this, Severity.WARNING, 3701)
-                    .message(tr("Building with an almost square angle"))
-                    .primitives(w)
-                    .highlight(n)
-                    .fix(() -> {
-                        try {
-                            return OrthogonalizeAction.orthogonalize(Collections.singleton(w));
-                        } catch (InvalidUserInputException e) {
-                            Logging.warn(e);
-                            return null;
-                        }
-                    })
-                    .build());
-            return false;
-        }
-
-        return true;
+        return difference > minAngleDelta && difference < maxAngleDelta;
     }
 }