Changeset 13616 in josm for trunk/test

Timestamp:

2018-04-11T22:38:52+02:00 (6 years ago)

Author:

Don-vip

Message:

use OsmDataLayer.getDataSet() in unit tests

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• command/DeleteCommandTest.java (modified) (1 diff)
• command/PurgeCommandTest.java (modified) (5 diffs)
• command/SelectCommandTest.java (modified) (6 diffs)
• command/conflict/ConflictAddCommandTest.java (modified) (2 diffs)
• data/osm/event/SelectionEventManagerTest.java (modified) (3 diffs)
• data/validation/tests/MapCSSTagCheckerTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/command/DeleteCommandTest.java

@@ -162 +162 @@
     @Test(expected = IllegalArgumentException.class)
     public void testConsistencyDataset() {
-        testData.layer.data.removePrimitive(testData.existingNode);
+        testData.layer.getDataSet().removePrimitive(testData.existingNode);
         new DeleteCommand(Arrays.asList(testData.existingNode, testData.existingWay));
     }

trunk/test/unit/org/openstreetmap/josm/command/PurgeCommandTest.java

@@ -63 +63 @@
         // to check that algorithm ignores it:
         Relation relationParent3 = testData.createRelation(102, new RelationMember("child", testData.existingRelation));
-        PurgeCommand command = new PurgeCommand(testData.layer.data,
+        PurgeCommand command = new PurgeCommand(testData.layer.getDataSet(),
                 Arrays.<OsmPrimitive>asList(testData.existingNode, testData.existingNode2, testData.existingWay,
                         testData.existingRelation, relationParent, relationParent2),
@@ -84 +84 @@
     @Test
     public void testUndo() {
-        PurgeCommand command = new PurgeCommand(testData.layer.data,
+        PurgeCommand command = new PurgeCommand(testData.layer.getDataSet(),
                 Arrays.<OsmPrimitive>asList(testData.existingNode, testData.existingWay),
                 Arrays.<OsmPrimitive>asList(testData.existingWay));
@@ -108 +108 @@
         ArrayList<OsmPrimitive> deleted = new ArrayList<>();
         ArrayList<OsmPrimitive> added = new ArrayList<>();
-        PurgeCommand command = new PurgeCommand(testData.layer.data, Arrays.<OsmPrimitive>asList(testData.existingNode),
+        PurgeCommand command = new PurgeCommand(testData.layer.getDataSet(), Arrays.<OsmPrimitive>asList(testData.existingNode),
                 Arrays.<OsmPrimitive>asList(testData.existingRelation));
         command.fillModifiedData(modified, deleted, added);
@@ -122 +122 @@
     @Test
     public void testGetParticipatingPrimitives() {
-        PurgeCommand command = new PurgeCommand(testData.layer.data, Arrays.<OsmPrimitive>asList(testData.existingNode),
+        PurgeCommand command = new PurgeCommand(testData.layer.getDataSet(), Arrays.<OsmPrimitive>asList(testData.existingNode),
                 Arrays.<OsmPrimitive>asList(testData.existingRelation));
         assertArrayEquals(new Object[] {testData.existingNode }, command.getParticipatingPrimitives().toArray());
@@ -133 +133 @@
     public void testDescription() {
         List<OsmPrimitive> shortList = Arrays.<OsmPrimitive>asList(testData.existingWay);
-        assertTrue(new PurgeCommand(testData.layer.data, shortList, Arrays.<OsmPrimitive>asList()).getDescriptionText()
+        assertTrue(new PurgeCommand(testData.layer.getDataSet(), shortList, Arrays.<OsmPrimitive>asList()).getDescriptionText()
                 .matches("Purged 1 object"));
         List<OsmPrimitive> longList = Arrays.<OsmPrimitive>asList(testData.existingNode, testData.existingNode2,
                 testData.existingWay);
-        assertTrue(new PurgeCommand(testData.layer.data, longList, Arrays.<OsmPrimitive>asList()).getDescriptionText()
+        assertTrue(new PurgeCommand(testData.layer.getDataSet(), longList, Arrays.<OsmPrimitive>asList()).getDescriptionText()
                 .matches("Purged 3 objects"));
     }

trunk/test/unit/org/openstreetmap/josm/command/SelectCommandTest.java

@@ -51 +51 @@
     @Test
     public void testExecute() {
-        SelectCommand command = new SelectCommand(testData.layer.data, Arrays.asList(testData.existingNode, testData.existingWay));
+        SelectCommand command = new SelectCommand(testData.layer.getDataSet(), Arrays.asList(testData.existingNode, testData.existingWay));
 
-        testData.layer.data.setSelected(Arrays.asList(testData.existingNode2));
+        testData.layer.getDataSet().setSelected(Arrays.asList(testData.existingNode2));
 
         command.executeCommand();
@@ -68 +68 @@
     public void testExecuteAfterModify() {
         List<OsmPrimitive> list = new ArrayList<>(Arrays.asList(testData.existingNode, testData.existingWay));
-        SelectCommand command = new SelectCommand(testData.layer.data, list);
+        SelectCommand command = new SelectCommand(testData.layer.getDataSet(), list);
 
         list.remove(testData.existingNode);
@@ -85 +85 @@
     @Test
     public void testUndo() {
-        SelectCommand command = new SelectCommand(testData.layer.data, Arrays.asList(testData.existingNode, testData.existingWay));
-        testData.layer.data.setSelected(Arrays.asList(testData.existingNode2));
+        SelectCommand command = new SelectCommand(testData.layer.getDataSet(), Arrays.asList(testData.existingNode, testData.existingWay));
+        testData.layer.getDataSet().setSelected(Arrays.asList(testData.existingNode2));
 
         command.executeCommand();
@@ -111 +111 @@
         ArrayList<OsmPrimitive> deleted = new ArrayList<>();
         ArrayList<OsmPrimitive> added = new ArrayList<>();
-        SelectCommand command = new SelectCommand(testData.layer.data, Arrays.asList(testData.existingNode, testData.existingWay));
+        SelectCommand command = new SelectCommand(testData.layer.getDataSet(), Arrays.asList(testData.existingNode, testData.existingWay));
         command.fillModifiedData(modified, deleted, added);
         // intentionally empty.
@@ -124 +124 @@
     @Test
     public void testGetParticipatingPrimitives() {
-        SelectCommand command = new SelectCommand(testData.layer.data, Arrays.asList(testData.existingNode));
+        SelectCommand command = new SelectCommand(testData.layer.getDataSet(), Arrays.asList(testData.existingNode));
         command.executeCommand();
         assertArrayEquals(new Object[] {testData.existingNode}, command.getParticipatingPrimitives().toArray());
@@ -134 +134 @@
     @Test
     public void testDescription() {
-        DataSet ds = testData.layer.data;
+        DataSet ds = testData.layer.getDataSet();
         assertTrue(new SelectCommand(ds, Arrays.<OsmPrimitive>asList(testData.existingNode))
                 .getDescriptionText().matches("Selected 1 object"));

trunk/test/unit/org/openstreetmap/josm/command/conflict/ConflictAddCommandTest.java

@@ -49 +49 @@
     @Test
     public void testExecuteUndoCommand() {
-        DataSet ds = testData.layer.data;
+        DataSet ds = testData.layer.getDataSet();
         Conflict<Node> conflict = new Conflict<>(testData.existingNode, testData.existingNode2);
         ConflictAddCommand cmd = new ConflictAddCommand(ds, conflict);
@@ -66 +66 @@
     public void testGetDescriptionIcon() {
         Conflict<Node> conflict = new Conflict<>(testData.existingNode, testData.existingNode2);
-        assertNotNull(new ConflictAddCommand(testData.layer.data, conflict).getDescriptionIcon());
+        assertNotNull(new ConflictAddCommand(testData.layer.getDataSet(), conflict).getDescriptionIcon());
     }
 

trunk/test/unit/org/openstreetmap/josm/data/osm/event/SelectionEventManagerTest.java

@@ -77 +77 @@
 
         // active layer, should change
-        testData1.layer.data.setSelected(testData1.existingNode.getPrimitiveId());
+        testData1.layer.getDataSet().setSelected(testData1.existingNode.getPrimitiveId());
         assertSelectionEquals(listeners, new HashSet<OsmPrimitive>(Arrays.asList(testData1.existingNode)));
 
-        testData1.layer.data.clearSelection(testData1.existingNode.getPrimitiveId());
+        testData1.layer.getDataSet().clearSelection(testData1.existingNode.getPrimitiveId());
         assertSelectionEquals(listeners, new HashSet<OsmPrimitive>(Arrays.asList()));
 
-        testData1.layer.data.addSelected(testData1.existingNode2.getPrimitiveId());
+        testData1.layer.getDataSet().addSelected(testData1.existingNode2.getPrimitiveId());
         assertSelectionEquals(listeners, new HashSet<OsmPrimitive>(Arrays.asList(testData1.existingNode2)));
 
@@ -91 +91 @@
 
         // This should not trigger anything, since the layer is not active any more.
-        testData1.layer.data.clearSelection(testData1.existingNode.getPrimitiveId());
+        testData1.layer.getDataSet().clearSelection(testData1.existingNode.getPrimitiveId());
         assertSelectionEquals(listeners, null);
 
-        testData2.layer.data.setSelected(testData2.existingNode.getPrimitiveId());
+        testData2.layer.getDataSet().setSelected(testData2.existingNode.getPrimitiveId());
         assertSelectionEquals(listeners, new HashSet<OsmPrimitive>(Arrays.asList(testData2.existingNode)));
 
@@ -104 +104 @@
 
         // no event triggered now
-        testData2.layer.data.setSelected(testData2.existingNode2.getPrimitiveId());
+        testData2.layer.getDataSet().setSelected(testData2.existingNode2.getPrimitiveId());
         assertSelectionEquals(listeners, null);
     }

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/MapCSSTagCheckerTest.java

@@ -26 +26 @@
 import org.openstreetmap.josm.command.SequenceCommand;
 import org.openstreetmap.josm.data.osm.DataSet;
+import org.openstreetmap.josm.data.osm.IPrimitive;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.OsmUtils;
@@ -233 +234 @@
             List<TestError> errors = test.getErrors();
             assertEquals(errorsCount, errors.size());
-            Set<Set<OsmPrimitive>> primitives = new HashSet<>();
+            Set<Set<IPrimitive>> primitives = new HashSet<>();
             for (TestError e : errors) {
                 primitives.add(new HashSet<>(e.getPrimitives()));