Changeset 13545 in josm

Timestamp:

2018-03-19T20:22:42+01:00 (6 years ago)

Author:

Don-vip

Message:

fix #16106 - disable search button arrow when button itself is disabled. Default behaviour of SideButton is not changed (as select button does not have the same logic)

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/search/SearchAction.java (modified) (1 diff)
• gui/SideButton.java (modified) (3 diffs)
• gui/dialogs/SelectionListDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -762 +762 @@
         static SearchTask newSearchTask(SearchSetting setting, SearchReceiver resultReceiver) {
             final DataSet ds = MainApplication.getLayerManager().getActiveDataSet();
+            if (ds == null) {
+                throw new IllegalStateException("No active dataset");
+            }
             return newSearchTask(setting, ds, resultReceiver);
         }

trunk/src/org/openstreetmap/josm/gui/SideButton.java

@@ -26 +26 @@
 
     private transient PropertyChangeListener propertyChangeListener;
+    private BasicArrowButton arrowButton;
+    private boolean arrowEnabledWithButton;
 
     /**
@@ -87 +89 @@
      */
     public BasicArrowButton createArrow(ActionListener listener) {
+        return createArrow(listener, false);
+    }
+
+    /**
+     * Create the arrow for opening a drop-down menu
+     * @param listener listener to use for button actions (e.g. pressing)
+     * @param enabledWithButton determines if the button arrow enabled state is the same as main button
+     * @return the created button
+     * @since 13545
+     */
+    public BasicArrowButton createArrow(ActionListener listener, boolean enabledWithButton) {
         setMargin(new Insets(0, 0, 0, 0));
-        BasicArrowButton arrowButton = new BasicArrowButton(SwingConstants.SOUTH, null, null, Color.BLACK, null);
+        arrowEnabledWithButton = enabledWithButton;
+        arrowButton = new BasicArrowButton(SwingConstants.SOUTH, null, null, Color.BLACK, null);
         arrowButton.setBorder(BorderFactory.createEmptyBorder());
         add(arrowButton, BorderLayout.EAST);
         arrowButton.addActionListener(listener);
+        if (arrowEnabledWithButton) {
+            arrowButton.setEnabled(isEnabled());
+        }
         return arrowButton;
+    }
+
+    @Override
+    public void setEnabled(boolean b) {
+        super.setEnabled(b);
+        if (arrowButton != null && arrowEnabledWithButton) {
+            arrowButton.setEnabled(b);
+        }
     }
 
@@ -107 +132 @@
             setAction(null);
         }
+        arrowButton = null;
     }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java

@@ -128 +128 @@
         // the search button
         final SideButton searchButton = new SideButton(actSearch);
-        searchButton.createArrow(e -> SearchPopupMenu.launch(searchButton));
+        searchButton.createArrow(e -> SearchPopupMenu.launch(searchButton), true);
 
         createLayout(lstPrimitives, true, Arrays.asList(