Changeset 13336 in josm

Timestamp:

2018-01-19T20:42:21+01:00 (7 years ago)

Author:

Don-vip

Message:

see #15800 - autofix out: issues in overpass queries

Location:

trunk

Files:

• src/org/openstreetmap/josm/io/OverpassDownloadReader.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/io/OverpassDownloadReaderTest.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/io/OverpassDownloadReader.java

@@ -402 +402 @@
      */
     public static String fixQuery(String query) {
-        return query.replaceFirst("out( body| skel| ids)?( id| qt)?;", "out meta$2;");
+        return query == null ? query : query
+                .replaceFirst("out( body| skel| ids)?( id| qt)?;", "out meta$2;")
+                .replaceFirst("(?s)\\[out:(json|csv)[^\\]]*\\]", "[out:xml]");
     }
 }

trunk/test/unit/org/openstreetmap/josm/io/OverpassDownloadReaderTest.java

@@ -8 +8 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
@@ -181 +182 @@
     @Test
     public void testFixQuery() {
+        assertNull(OverpassDownloadReader.fixQuery(null));
+
         assertEquals("out meta;", OverpassDownloadReader.fixQuery("out;"));
         assertEquals("out meta;", OverpassDownloadReader.fixQuery("out body;"));
@@ -196 +199 @@
         assertEquals("out meta qt;", OverpassDownloadReader.fixQuery("out ids qt;"));
 
-        assertEquals("[timeout:25];\n" +
+        assertEquals("[out:xml]", OverpassDownloadReader.fixQuery("[out:json]"));
+        assertEquals("[out:xml]", OverpassDownloadReader.fixQuery("[out:csv(\n" +
+                "    ::\"id\", amenity, name, operator, opening_hours, \"contact:website\", \"contact:phone\", brand, dispensing, lastcheck\n" +
+                "  )]"));
+
+        assertEquals("[out:xml][timeout:25];\n" +
                 "(\n" +
                 "  node[\"historic\"=\"ringfort\"];\n" +
@@ -202 +210 @@
                 ");\n" +
                 "out meta;",
-            OverpassDownloadReader.fixQuery("[timeout:25];\n" +
+            OverpassDownloadReader.fixQuery("[out:xml][timeout:25];\n" +
                 "(\n" +
                 "  node[\"historic\"=\"ringfort\"];\n" +