Changeset 1332 in josm for trunk/src

Timestamp:

2009-01-24T23:45:58+01:00 (15 years ago)

Author:

stoecker

Message:

better handling of ToggleDialog docking

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/Preferences.java (modified) (1 diff)
• gui/MapFrame.java (modified) (4 diffs)
• gui/dialogs/ToggleDialog.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -475 +475 @@
         String s = get(key);
         if(s != null && s.length() != 0)
-        {
-            /* handle old comma separated stuff - remove in future */
-            if(s.indexOf(',') >= 0)
-                return Arrays.asList(s.split(","));
-            /* handle space separated stuff - remove in future */
-            else if(s.indexOf(' ') >= 0)
-                return Arrays.asList(s.split(" "));
-            else
-                return Arrays.asList(s.split(";"));
-        }
+           return Arrays.asList(s.split(";"));
         return def;
     }

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -6 +6 @@
 import java.awt.Component;
 import java.awt.Container;
+import java.util.ArrayList;
 
 import javax.swing.AbstractButton;
@@ -70 +71 @@
      */
     public JPanel toggleDialogs = new JPanel();
+    public ArrayList<ToggleDialog> allDialogs = new ArrayList<ToggleDialog>();
 
     public final ButtonGroup toolGroup = new ButtonGroup();
@@ -116 +118 @@
      */
     public void destroy() {
+        for (ToggleDialog t : allDialogs)
+            t.close();
         for (int i = 0; i < toolBarActions.getComponentCount(); ++i)
             if (toolBarActions.getComponent(i) instanceof Destroyable)
@@ -154 +158 @@
         toolBarToggle.add(button);
         toggleDialogs.add(dlg);
+        allDialogs.add(dlg);
         return button;
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -60 +60 @@
             if(!selected && winadapter != null)
                 winadapter.windowClosing(null);
+            else if (!Main.pref.getBoolean(action.prefname+".docked", true)) {
+                EventQueue.invokeLater(new Runnable(){
+                    public void run() {
+                        stickyActionListener.actionPerformed(null);
+                    }
+                });
+            }
         }
     }
@@ -71 +78 @@
     public JPanel parent;
     WindowAdapter winadapter;
+    private ActionListener stickyActionListener;
     private final JPanel titleBar = new JPanel(new GridBagLayout());
     public JLabel label = new JLabel();
@@ -151 +159 @@
         sticky.setToolTipText(tr("Undock the panel"));
         sticky.setBorder(BorderFactory.createEmptyBorder());
-        final ActionListener stickyActionListener = new ActionListener(){
+        stickyActionListener = new ActionListener(){
             public void actionPerformed(ActionEvent e) {
                 final JFrame f = new JFrame(name);
@@ -169 +177 @@
                             setVisible(true);
                         titleBar.setVisible(true);
-                        Main.pref.put(action.prefname+".docked", true);
+                        if(e != null)
+                            Main.pref.put(action.prefname+".docked", true);
                     }
                 }));
@@ -230 +239 @@
     }
 
+    public void close()
+    {
+        if(winadapter != null)
+            winadapter.windowClosing(null);
+    }
+
     public void setTitle(String title, boolean active) {
         if(active) {