Changeset 13115 in josm

Timestamp:

2017-11-12T02:32:10+01:00 (6 years ago)

Author:

Don-vip

Message:

fix #12086 - fix EDT violation when no file exporter is found + choose note exporter by default when saving a note layer

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/SaveActionBase.java (modified) (2 diffs)
• gui/io/LayerNameAndFilePathTableCell.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/actions/SaveActionBase.java

@@ -21 +21 @@
 import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.gui.widgets.AbstractFileChooser;
 import org.openstreetmap.josm.spi.preferences.Config;
@@ -105 +106 @@
             }
             if (!exported) {
-                JOptionPane.showMessageDialog(Main.parent, tr("No Exporter found! Nothing saved."), tr("Warning"),
-                        JOptionPane.WARNING_MESSAGE);
+                GuiHelper.runInEDTAndWait(() ->
+                    JOptionPane.showMessageDialog(Main.parent, tr("No Exporter found! Nothing saved."), tr("Warning"),
+                        JOptionPane.WARNING_MESSAGE));
                 return false;
             } else if (canceled) {

trunk/src/org/openstreetmap/josm/gui/io/LayerNameAndFilePathTableCell.java

@@ -26 +26 @@
 
 import org.openstreetmap.josm.actions.SaveActionBase;
+import org.openstreetmap.josm.gui.layer.NoteLayer;
 import org.openstreetmap.josm.gui.util.CellEditorSupport;
 import org.openstreetmap.josm.gui.widgets.JosmTextField;
@@ -49 +50 @@
 
     private final transient CellEditorSupport cellEditorSupport = new CellEditorSupport(this);
+    private String extension = "osm";
     private File value;
 
@@ -90 +92 @@
           .append(addLblLayerName(info));
         if (info.isSavable()) {
+            extension = info.getLayer() instanceof NoteLayer ? "osn" : "osm";
             add(btnFileChooser, GBC.std());
             sb.append("<br>")
@@ -111 +114 @@
 
         if (info.isSavable()) {
+            extension = info.getLayer() instanceof NoteLayer ? "osn" : "osm";
             add(btnFileChooser, GBC.std());
             add(tfFilename, GBC.eol().fill(GBC.HORIZONTAL).insets(1, 0, 0, 0));
@@ -242 +246 @@
         @Override
         public void actionPerformed(ActionEvent e) {
-            File f = SaveActionBase.createAndOpenSaveFileChooser(tr("Select filename"), "osm");
+            File f = SaveActionBase.createAndOpenSaveFileChooser(tr("Select filename"), extension);
             if (f != null) {
                 tfFilename.setText(f.toString());