Changeset 12798 in josm for trunk/src

Timestamp:

2017-09-09T14:00:39+02:00 (7 years ago)

Author:

Don-vip

Message:

see #14794 - checkstyle

Location:

trunk/src/org/openstreetmap/josm/tools

Files:

• Diff.java (modified) (1 diff)
• HiDPISupport.java (modified) (1 diff)
• ImageResource.java (modified) (1 diff)
• ImageWarp.java (modified) (1 diff)
• ListenableWeakReference.java (modified) (1 diff)
• ListenerList.java (modified) (1 diff)
• Logging.java (modified) (1 diff)
• MultikeyActionsHandler.java (modified) (1 diff)
• Utils.java (modified) (5 diffs)
• template_engine/CompoundTemplateEntry.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/tools/Diff.java

@@ -570 +570 @@
          * @see #equivCount()
          */
-        private byte[] discardable(final int ... counts) {
+        private byte[] discardable(final int... counts) {
             final int end = bufferedLines;
             final byte[] discards = new byte[end];

trunk/src/org/openstreetmap/josm/tools/HiDPISupport.java

@@ -28 +28 @@
  * @since 12722
  */
-public class HiDPISupport {
+public final class HiDPISupport {
 
     private static volatile Optional<Class<? extends Image>> baseMultiResolutionImageClass;
     private static volatile Optional<Constructor<? extends Image>> baseMultiResolutionImageConstructor;
     private static volatile Optional<Method> resolutionVariantsMethod;
+
+    private HiDPISupport() {
+        // Hide default constructor
+    }
 
     /**

trunk/src/org/openstreetmap/josm/tools/ImageResource.java

@@ -137 +137 @@
      * @param  dim The requested dimensions. Use (-1,-1) for the original size and (width, -1)
      *         to set the width, but otherwise scale the image proportionally.
+     * @return ImageIcon object for the image of this resource, scaled according to dim
      * @see #getImageIconBounded(java.awt.Dimension, boolean)
-     * @return ImageIcon object for the image of this resource, scaled according to dim
      */
     public ImageIcon getImageIcon(Dimension dim) {

trunk/src/org/openstreetmap/josm/tools/ImageWarp.java

@@ -17 +17 @@
  * @since 11858
  */
-public class ImageWarp {
+public final class ImageWarp {
+
+    private ImageWarp() {
+        // Hide default constructor
+    }
 
     /**

trunk/src/org/openstreetmap/josm/tools/ListenableWeakReference.java

@@ -13 +13 @@
  * A special dereferenced-thread is used for this, so make sure your code is thread-safe.
  * @author Michael Zangl
+ * @param <T> The weak reference
  * @since 12181
- *
- * @param <T> The weak reference
  */
 public class ListenableWeakReference<T> extends WeakReference<T> {

trunk/src/org/openstreetmap/josm/tools/ListenerList.java

@@ -210 +210 @@
         }
 
-        private static void dumpStack(StackTraceElement ... stackTraceElements) {
+        private static void dumpStack(StackTraceElement... stackTraceElements) {
             if (stackTraceElements == null) {
                 Logging.trace("  - (no trace recorded)");

trunk/src/org/openstreetmap/josm/tools/Logging.java

@@ -280 +280 @@
      */
     public static void logWithStackTrace(Level level, Throwable t, String pattern, Object... args) {
-        logPrivate(level, () -> getErrorLogWithStack(MessageFormat.format(pattern,  args), t));
+        logPrivate(level, () -> getErrorLogWithStack(MessageFormat.format(pattern, args), t));
     }
 

trunk/src/org/openstreetmap/josm/tools/MultikeyActionsHandler.java

@@ -148 +148 @@
             lastAction = this;
             timer.schedule(new MyTimerTask(lastTimestamp, lastAction), DIALOG_DELAY);
-            MainApplication.getMap().statusLine.setHelpText(STATUS_BAR_ID, tr("{0}... [please type its number]", (String) action.getValue(SHORT_DESCRIPTION)));
+            MainApplication.getMap().statusLine.setHelpText(STATUS_BAR_ID,
+                    tr("{0}... [please type its number]", (String) action.getValue(SHORT_DESCRIPTION)));
         }
 

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -345 +345 @@
      * @since 6222
      */
-    public static char[] copyArray(char ... array) {
+    public static char[] copyArray(char... array) {
         if (array != null) {
             return Arrays.copyOf(array, array.length);
@@ -812 +812 @@
     }
 
-    private static String strip(final String str, final char ... skipChars) {
+    private static String strip(final String str, final char... skipChars) {
 
         int start = 0;
@@ -834 +834 @@
     }
 
-    private static boolean isStrippedChar(char c, final char ... skipChars) {
+    private static boolean isStrippedChar(char c, final char... skipChars) {
         return Character.isWhitespace(c) || Character.isSpaceChar(c) || stripChar(skipChars, c);
     }
@@ -1496 +1496 @@
      * @since 10223
      */
-    public static void setObjectsAccessible(final AccessibleObject ... objects) {
+    public static void setObjectsAccessible(final AccessibleObject... objects) {
         if (objects != null && objects.length > 0) {
             AccessController.doPrivileged((PrivilegedAction<Object>) () -> {
@@ -1626 +1626 @@
             return 0;
         }
-        return firstDotPos > - 1 ? Integer.parseInt(version.substring(firstDotPos + 1,
+        return firstDotPos > -1 ? Integer.parseInt(version.substring(firstDotPos + 1,
                 lastDotPos > -1 ? lastDotPos : version.length())) : 0;
     }

trunk/src/org/openstreetmap/josm/tools/template_engine/CompoundTemplateEntry.java

@@ -13 +13 @@
     }
 
-    private CompoundTemplateEntry(TemplateEntry ... entries) {
+    private CompoundTemplateEntry(TemplateEntry... entries) {
         this.entries = entries;
     }