Changeset 12767 in josm

Timestamp:

2017-09-07T01:05:36+02:00 (7 years ago)

Author:

Don-vip

Message:

see #15229 - see #15182 - do not longer fire ChangesetCacheEvent in EDT - now up to listeners to run their code in it if required

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/ChangesetCache.java (modified) (3 diffs)
• gui/dialogs/changeset/ChangesetCacheManagerModel.java (modified) (1 diff)
• gui/dialogs/changeset/ChangesetListModel.java (modified) (2 diffs)
• gui/io/OpenChangesetComboBoxModel.java (modified) (2 diffs)
• io/MessageNotifier.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/ChangesetCache.java

@@ -16 +16 @@
 import org.openstreetmap.josm.data.Preferences.PreferenceChangedListener;
 import org.openstreetmap.josm.data.UserIdentityManager;
-import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.tools.SubclassFilteredCollection;
 
@@ -32 +31 @@
  * clears itself if the OSM API URL is changed in the preferences.
  *
- * {@link ChangesetCacheEvent}s are delivered on the EDT.
- *
  */
 public final class ChangesetCache implements PreferenceChangedListener {
@@ -80 +77 @@
 
     private void fireChangesetCacheEvent(final ChangesetCacheEvent e) {
-        GuiHelper.runInEDT(() -> {
-            for (ChangesetCacheListener l: listeners) {
-                l.changesetCacheUpdated(e);
-            }
-        });
+        for (ChangesetCacheListener l: listeners) {
+            l.changesetCacheUpdated(e);
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheManagerModel.java

@@ -198 +198 @@
             }
         }
-        sort();
-        fireTableDataChanged();
-        setSelectedChangesets(selected);
+        GuiHelper.runInEDT(() -> {
+            sort();
+            fireTableDataChanged();
+            setSelectedChangesets(selected);
+        });
     }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetListModel.java

@@ -19 +19 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Storage;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 
 /**
@@ -228 +229 @@
             }
         }
-        fireContentsChanged(this, 0, getSize());
-        setSelectedChangesets(sel);
+        GuiHelper.runInEDT(() -> {
+            fireContentsChanged(this, 0, getSize());
+            setSelectedChangesets(sel);
+        });
     }
 }

trunk/src/org/openstreetmap/josm/gui/io/OpenChangesetComboBoxModel.java

@@ -11 +11 @@
 import org.openstreetmap.josm.data.osm.ChangesetCacheEvent;
 import org.openstreetmap.josm.data.osm.ChangesetCacheListener;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 
 /**
@@ -67 +68 @@
     @Override
     public void changesetCacheUpdated(ChangesetCacheEvent event) {
-        refresh();
+        GuiHelper.runInEDT(this::refresh);
     }
 

trunk/src/org/openstreetmap/josm/io/MessageNotifier.java

@@ -35 +35 @@
     /**
      * Called when new new messages are detected.
-     * @since xxx
+     * @since 12766
      */
     @FunctionalInterface