Changeset 1235 in josm

Timestamp:

2009-01-10T20:51:48+01:00 (15 years ago)

Author:

ulfl

Message:

first set of performance optimizations:

• don't call Main.pref.get() when getting a style name, cache the name and only update once for each visitAll

• check first, if a Way/Node to display is visible at all

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/visitor/MapPaintVisitor.java (modified) (9 diffs)
• data/osm/visitor/SimplePaintVisitor.java (modified) (2 diffs)
• gui/mappaint/ElemStyles.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/visitor/MapPaintVisitor.java

@@ -76 +76 @@
      */
     public void visit(Node n) {
+        // check, if the node is visible at all
+        Point p = nc.getPoint(n.eastNorth);
+        if ((p.x < 0) || (p.y < 0) || (p.x > nc.getWidth()) || (p.y > nc.getHeight())) return;
+        
         IconElemStyle nodeStyle = (IconElemStyle)styles.get(n);
         if (nodeStyle != null && isZoomOk(nodeStyle))
@@ -95 +99 @@
             return;
 
+        // check, if the way is visible at all
+        Polygon polygon = new Polygon();
+        for (Node n : w.nodes)
+        {
+            Point p = nc.getPoint(n.eastNorth);
+            polygon.addPoint(p.x,p.y);
+        }
+        if(!isPolygonVisible(polygon))
+            return;
+        
         ElemStyle wayStyle = styles.get(w);
 
@@ -104 +118 @@
         if(wayStyle!=null)
         {
-            boolean area = false;
             if(wayStyle instanceof LineElemStyle)
                 l = (LineElemStyle)wayStyle;
@@ -111 +124 @@
                 areacolor = ((AreaElemStyle)wayStyle).color;
                 l = ((AreaElemStyle)wayStyle).line;
-                area = true;
-            }
-            if (area && fillAreas)
-                drawWayAsArea(w, areacolor);
+                if (fillAreas)
+                    drawWayAsArea(w, areacolor);
+            }
         }
 
@@ -129 +141 @@
         int realWidth = 0; //the real width of the element in meters
         boolean dashed = false;
+        Node lastN;
 
         if(l != null)
@@ -147 +160 @@
             color = selectedColor;
 
-        Node lastN;
+        // draw overlays under the way
         if(l != null && l.overlays != null)
         {
@@ -168 +181 @@
         }
 
+        // draw the way
         lastN = null;
         for(Node n : w.nodes)
@@ -176 +190 @@
         }
 
+        // draw overlays above the way
         if(l != null && l.overlays != null)
         {
@@ -799 +814 @@
         alreadyDrawnAreas = new LinkedList<Way>();
         selectedCall = false;
-
+        
+        // update the style name, just in case the user changed it in the meantime
+        styles.updateStyleName();
+        
         if(profiler) 
         {

trunk/src/org/openstreetmap/josm/data/osm/visitor/SimplePaintVisitor.java

@@ -9 +9 @@
 import java.awt.Graphics2D;
 import java.awt.Point;
+import java.awt.Polygon;
 import java.awt.Rectangle;
 import java.awt.RenderingHints;
@@ -357 +358 @@
     }
 
+    protected boolean isPolygonVisible(Polygon polygon) {
+        Rectangle bounds = polygon.getBounds();
+                if (bounds.x > nc.getWidth()) return false;
+                else if (bounds.y > nc.getHeight()) return false;
+                else if (bounds.x + polygon.getBounds().width < 0) return false;
+                else if (bounds.y + polygon.getBounds().height < 0) return false;
+        
+        return true;
+    }
+        
     public void setGraphics(Graphics g) {
         this.g = g;

trunk/src/org/openstreetmap/josm/gui/mappaint/ElemStyles.java

@@ -31 +31 @@
     }
     HashMap<String, StyleSet> styleSet;
+    String styleName;
 
     public ElemStyles()
     {
         styleSet = new HashMap<String, StyleSet>();
+        updateStyleName();
+    }
+
+    public void updateStyleName() {
+        // Main.pref.get() is slow when done thousands of times, do it once here and cache it
+        styleName = Main.pref.get("mappaint.style", "standard");
     }
 
@@ -78 +85 @@
     {
         if(name == null)
-            name = Main.pref.get("mappaint.style", "standard");
+            name = styleName;
         StyleSet s = styleSet.get(name);
         if(create && s == null)