Changeset 12317 in josm

Timestamp:

2017-06-04T21:33:56+02:00 (7 years ago)

Author:

michael2402

Message:

Remove dupplicate code/state in MapMover

File:

• trunk/src/org/openstreetmap/josm/gui/MapMover.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/gui/MapMover.java

@@ -23 +23 @@
 import org.openstreetmap.josm.data.coor.EastNorth;
 import org.openstreetmap.josm.data.preferences.BooleanProperty;
+import org.openstreetmap.josm.gui.MapViewState.MapViewPoint;
 import org.openstreetmap.josm.tools.Destroyable;
 import org.openstreetmap.josm.tools.Pair;
@@ -35 +36 @@
 public class MapMover extends MouseAdapter implements Destroyable {
 
+    /**
+     * Zoom wheel is reversed.
+     */
     public static final BooleanProperty PROP_ZOOM_REVERSE_WHEEL = new BooleanProperty("zoom.reverse-wheel", false);
 
@@ -104 +108 @@
      * The point in the map that was the under the mouse point
      * when moving around started.
-     */
-    private EastNorth mousePosMove;
+     *
+     * This is <code>null</code> if movement is not active
+     */
+    private MapViewPoint mousePosMoveStart;
+
     /**
      * The map to move around.
      */
     private final NavigatableComponent nc;
-
-    private boolean movementInPlace;
 
     private final ArrayList<Pair<ZoomerAction, Shortcut>> registeredShortcuts = new ArrayList<>();
@@ -152 +157 @@
     }
 
+    private boolean movementInProgress() {
+        return mousePosMoveStart != null;
+    }
+
     /**
      * If the right (and only the right) mouse button is pressed, move the map.
@@ -158 +167 @@
     public void mouseDragged(MouseEvent e) {
         int offMask = MouseEvent.BUTTON1_DOWN_MASK | MouseEvent.BUTTON2_DOWN_MASK;
-        int macMouseMask = MouseEvent.CTRL_DOWN_MASK | MouseEvent.BUTTON1_DOWN_MASK;
-        boolean stdMovement = (e.getModifiersEx() & (MouseEvent.BUTTON3_DOWN_MASK | offMask)) == MouseEvent.BUTTON3_DOWN_MASK;
-        boolean macMovement = Main.isPlatformOsx() && e.getModifiersEx() == macMouseMask;
-        boolean allowedMode = !Main.map.mapModeSelect.equals(Main.map.mapMode)
-                          || SelectAction.Mode.SELECT.equals(Main.map.mapModeSelect.getMode());
-        if (stdMovement || (macMovement && allowedMode)) {
-            if (mousePosMove == null)
-                startMovement(e);
-            EastNorth center = nc.getCenter();
-            EastNorth mouseCenter = nc.getEastNorth(e.getX(), e.getY());
-            nc.zoomTo(new EastNorth(
-                    mousePosMove.east() + center.east() - mouseCenter.east(),
-                    mousePosMove.north() + center.north() - mouseCenter.north()));
+        boolean allowMovement = (e.getModifiersEx() & (MouseEvent.BUTTON3_DOWN_MASK | offMask)) == MouseEvent.BUTTON3_DOWN_MASK;
+        if (Main.isPlatformOsx()) {
+            int macMouseMask = MouseEvent.CTRL_DOWN_MASK | MouseEvent.BUTTON1_DOWN_MASK;
+            boolean macMovement = true && e.getModifiersEx() == macMouseMask;
+            boolean allowedMode = !Main.map.mapModeSelect.equals(Main.map.mapMode)
+                              || SelectAction.Mode.SELECT.equals(Main.map.mapModeSelect.getMode());
+            allowMovement |= macMovement && allowedMode;
+        }
+        if (allowMovement) {
+            doMoveForDrag(e);
         } else {
             endMovement();
         }
+    }
+
+    private void doMoveForDrag(MouseEvent e) {
+        if (!movementInProgress()) {
+            startMovement(e);
+        }
+        EastNorth center = nc.getCenter();
+        EastNorth mouseCenter = nc.getEastNorth(e.getX(), e.getY());
+        nc.zoomTo(mousePosMoveStart.getEastNorth().add(center).subtract(mouseCenter));
     }
 
@@ -205 +220 @@
      */
     private void startMovement(MouseEvent e) {
-        if (movementInPlace)
+        if (movementInProgress()) {
             return;
-        movementInPlace = true;
-        mousePosMove = nc.getEastNorth(e.getX(), e.getY());
+        }
+        mousePosMoveStart = nc.getState().getForView(e.getX(), e.getY());
         nc.setNewCursor(Cursor.MOVE_CURSOR, this);
     }
@@ -216 +231 @@
      */
     private void endMovement() {
-        if (!movementInPlace)
+        if (!movementInProgress()) {
             return;
-        movementInPlace = false;
+        }
         nc.resetCursor(this);
-        mousePosMove = null;
+        mousePosMoveStart = null;
     }
 
@@ -238 +253 @@
     @Override
     public void mouseMoved(MouseEvent e) {
-        if (!movementInPlace)
+        if (!movementInProgress()) {
             return;
+        }
         // Mac OSX simulates with  ctrl + mouse 1  the second mouse button hence no dragging events get fired.
         // Is only the selected mouse button pressed?
         if (Main.isPlatformOsx()) {
             if (e.getModifiersEx() == MouseEvent.CTRL_DOWN_MASK) {
-                if (mousePosMove == null) {
-                    startMovement(e);
-                }
-                EastNorth center = nc.getCenter();
-                EastNorth mouseCenter = nc.getEastNorth(e.getX(), e.getY());
-                nc.zoomTo(new EastNorth(mousePosMove.east() + center.east() - mouseCenter.east(), mousePosMove.north()
-                        + center.north() - mouseCenter.north()));
+                doMoveForDrag(e);
             } else {
                 endMovement();