Changeset 12058 in josm for trunk/src/org/openstreetmap

Timestamp:

2017-05-04T09:53:02+02:00 (8 years ago)

Author:

Don-vip

Message:

fix Java/PMD/Checkstyle warnings

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/DataSelectionListener.java (modified) (1 diff)
• data/osm/DataSet.java (modified) (1 diff)
• data/osm/visitor/paint/StyledMapRenderer.java (modified) (1 diff)
• gui/conflict/pair/properties/PropertiesMerger.java (modified) (1 diff)
• gui/tagging/presets/TaggingPresets.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/DataSelectionListener.java

@@ -29 +29 @@
      * @since 12048
      */
-    public interface SelectionChangeEvent {
+    interface SelectionChangeEvent {
         /**
          * Gets the previous selection

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -1245 +1245 @@
         beginUpdate();
         try {
-            Collection<OsmPrimitive> toCleanUp = getPrimitives(primitive -> primitive.isDeleted() && (!primitive.isVisible() || primitive.isNew()));
+            Collection<OsmPrimitive> toCleanUp = getPrimitives(
+                    primitive -> primitive.isDeleted() && (!primitive.isVisible() || primitive.isNew()));
             if (!toCleanUp.isEmpty()) {
                 clearSelection(toCleanUp.stream().map(OsmPrimitive::getPrimitiveId));

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -143 +143 @@
          */
         private static long floatToFixed(double number, int totalBits, int afterDecimalBits) {
-            long value = (long) (number * (1l << afterDecimalBits));
-            long highestBitMask = 1l << totalBits - 1;
+            long value = (long) (number * (1L << afterDecimalBits));
+            long highestBitMask = 1L << totalBits - 1;
             long valueMask = highestBitMask - 1;
             long signBit = number < 0 ? 0 : highestBitMask;

trunk/src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMerger.java

@@ -330 +330 @@
     }
 
-    private final class EmptyFillRow extends AbstractMergePanel.MergeRow {
+    private static final class EmptyFillRow extends AbstractMergePanel.MergeRow {
         @Override
         protected JComponent merged() {

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresets.java

@@ -115 +115 @@
             KeyedItem ki = (KeyedItem) item;
             if (ki.key != null && ki.getValues() != null) {
-                try {
-                    PRESET_TAG_CACHE.putAll(ki.key, ki.getValues());
-                } catch (NullPointerException e) {
-                    Main.error(e, p + ": Unable to cache " + ki);
-                }
+                PRESET_TAG_CACHE.putAll(ki.key, ki.getValues());
             }
         } else if (item instanceof Roles) {