Changeset 11810 in josm for trunk

Timestamp:

2017-04-01T02:11:32+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• mappaint/styleelement/placement/CompletelyInsideAreaStrategy.java (modified) (1 diff)
• preferences/imagery/CommonSettingsPanel.java (modified) (1 diff)
• preferences/imagery/ImageryPreference.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/placement/CompletelyInsideAreaStrategy.java

@@ -86 +86 @@
     }
 
-    private MapViewPositionAndRotation centerOf(MapViewState mapViewState, Rectangle centeredNBounds) {
+    private static MapViewPositionAndRotation centerOf(MapViewState mapViewState, Rectangle centeredNBounds) {
         return new MapViewPositionAndRotation(
                 mapViewState.getForView(centeredNBounds.getCenterX(), centeredNBounds.getCenterY()), 0);

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/CommonSettingsPanel.java

@@ -114 +114 @@
     }
 
-    private void removeCacheFiles(String path) {
+    private static void removeCacheFiles(String path) {
         File directory = new File(path);
         File[] cacheFiles = directory.listFiles((FilenameFilter) (dir, name) -> name.endsWith(".data") || name.endsWith(".key"));

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java

@@ -866 +866 @@
             }
 
-            private OffsetBookmark getRow(int row) {
+            private static OffsetBookmark getRow(int row) {
                 return OffsetBookmark.getBookmarkByIndex(row);
             }