Changeset 1180 in josm for trunk/src/org/openstreetmap

Timestamp:

2008-12-25T18:58:04+01:00 (16 years ago)

Author:

stoecker

Message:

fixed bug #1871, removed all deprecations

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/DiskAccessAction.java (modified) (1 diff)
• actions/JosmAction.java (modified) (4 diffs)
• actions/SaveActionBase.java (modified) (1 diff)
• actions/audio/AudioFastSlowAction.java (modified) (1 diff)
• actions/mapmode/MapMode.java (modified) (1 diff)
• data/Preferences.java (modified) (7 diffs)
• data/osm/DataSet.java (modified) (1 diff)
• data/osm/Way.java (modified) (1 diff)
• gui/MainMenu.java (modified) (2 diffs)
• gui/MapFrame.java (modified) (5 diffs)
• gui/MapView.java (modified) (6 diffs)
• gui/ScrollViewport.java (added)
• gui/SideButton.java (modified) (1 diff)
• gui/dialogs/ToggleDialog.java (modified) (1 diff)
• gui/layer/OsmDataLayer.java (modified) (1 diff)
• gui/preferences/AdvancedPreference.java (modified) (2 diffs)
• gui/preferences/AudioPreference.java (modified) (2 diffs)
• gui/preferences/ColorPreference.java (modified) (1 diff)
• gui/preferences/DrawingPreference.java (modified) (2 diffs)
• gui/preferences/FilePreferences.java (modified) (1 diff)
• gui/preferences/LafPreference.java (modified) (2 diffs)
• gui/preferences/LanguagePreference.java (modified) (2 diffs)
• gui/preferences/MapPaintPreference.java (modified) (1 diff)
• gui/preferences/PluginPreference.java (modified) (3 diffs)
• gui/preferences/PreferenceDialog.java (modified) (2 diffs)
• gui/preferences/PreferenceSetting.java (modified) (1 diff)
• gui/preferences/ProjectionPreference.java (modified) (2 diffs)
• gui/preferences/ProxyPreferences.java (modified) (2 diffs)
• gui/preferences/ServerAccessPreference.java (modified) (1 diff)
• gui/preferences/ShortcutPreference.java (modified) (2 diffs)
• gui/preferences/TaggingPresetPreference.java (modified) (6 diffs)
• gui/preferences/ToolbarPreferences.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/DiskAccessAction.java

@@ -19 +19 @@
     public DiskAccessAction(String name, String iconName, String tooltip, Shortcut shortcut) {
         super(name, iconName, tooltip, shortcut, true);
-    }
-
-    @Deprecated
-    public DiskAccessAction(String name, String iconName, String tooltip, int shortcut, int modifiers) {
-        super(name, iconName, tooltip, shortcut, modifiers, true);
     }
 

trunk/src/org/openstreetmap/josm/actions/JosmAction.java

@@ -25 +25 @@
 abstract public class JosmAction extends AbstractAction implements Destroyable {
 
-    @Deprecated
-    public KeyStroke shortcut;
     protected Shortcut sc;
 
@@ -36 +34 @@
         }
         return sc;
-    }
-
-    @Deprecated
-    public JosmAction(String name, String iconName, String tooltip, int shortcut, int modifier, boolean register) {
-        super(name, iconName == null ? null : ImageProvider.get(iconName));
-        setHelpId();
-        if (shortcut != 0) {
-            int group = Shortcut.GROUP_LAYER; //GROUP_NONE;
-            if (((modifier & InputEvent.CTRL_MASK) != 0) || ((modifier & InputEvent.CTRL_DOWN_MASK) != 0)) {
-                group = Shortcut.GROUP_MENU;
-            } else if (modifier == 0) {
-                group = Shortcut.GROUP_EDIT;
-            }
-            sc = Shortcut.registerShortcut("auto:"+name, name, shortcut, group);
-            this.shortcut = sc.getKeyStroke();
-            Main.contentPane.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(sc.getKeyStroke(), name);
-            Main.contentPane.getActionMap().put(name, this);
-        }
-        putValue(SHORT_DESCRIPTION, Main.platform.makeTooltip(tooltip, sc));
-        putValue("toolbar", iconName);
-    if (register)
-        Main.toolbar.register(this);
     }
 
@@ -80 +56 @@
         sc = shortcut;
         if (sc != null) {
-            this.shortcut = sc.getKeyStroke();
             Main.contentPane.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(sc.getKeyStroke(), name);
             Main.contentPane.getActionMap().put(name, this);
@@ -91 +66 @@
 
     public void destroy() {
-        if (shortcut != null) {
+        if (sc != null) {
             Main.contentPane.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).remove(sc.getKeyStroke());
             Main.contentPane.getActionMap().remove(sc.getKeyStroke());

trunk/src/org/openstreetmap/josm/actions/SaveActionBase.java

@@ -30 +30 @@
     public SaveActionBase(String name, String iconName, String tooltip, Shortcut shortcut, Layer layer) {
         super(name, iconName, tooltip, shortcut);
-        this.layer = layer;
-    }
-
-    @Deprecated
-    public SaveActionBase(String name, String iconName, String tooltip, int shortcut, int modifiers, Layer layer) {
-        super(name, iconName, tooltip, shortcut, modifiers);
         this.layer = layer;
     }

trunk/src/org/openstreetmap/josm/actions/audio/AudioFastSlowAction.java

@@ -24 +24 @@
     }
 
-    @Deprecated
-    public AudioFastSlowAction(String name, String iconName, String tooltip, int shortcut, int modifier, boolean fast) {
-        super(name, iconName, tooltip, shortcut, modifier, true);
-        try {
-            multiplier = Double.parseDouble(Main.pref.get("audio.fastfwdmultiplier","1.3"));
-        } catch (NumberFormatException e) {
-            multiplier = 1.3;
-        }
-        if (! fast)
-            multiplier = 1.0 / multiplier;
-    }
-
     public void actionPerformed(ActionEvent e) {
         double speed = AudioPlayer.speed();

trunk/src/org/openstreetmap/josm/actions/mapmode/MapMode.java

@@ -31 +31 @@
     public MapMode(String name, String iconName, String tooltip, Shortcut shortcut, MapFrame mapFrame, Cursor cursor) {
         super(name, "mapmode/"+iconName, tooltip, shortcut, false);
-        this.cursor = cursor;
-        putValue("active", false);
-    }
-
-    /**
-     * Constructor for mapmodes without an menu
-     */
-     @Deprecated
-    public MapMode(String name, String iconName, String tooltip, int keystroke, MapFrame mapFrame, Cursor cursor) {
-        super(name, "mapmode/"+iconName, tooltip, keystroke, 0, false);
         this.cursor = cursor;
         putValue("active", false);

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -208 +208 @@
     }
 
-    synchronized public void put(final String key, String value) {
+    synchronized public boolean put(final String key, String value) {
         String oldvalue = properties.get(key);
         if(value != null && value.length() == 0)
@@ -221 +221 @@
             save();
             firePreferenceChanged(key, value);
-        }
-    }
-
-    synchronized public void put(final String key, final boolean value) {
-        put(key, Boolean.toString(value));
+            return true;
+        }
+        return false;
+    }
+
+    synchronized public boolean put(final String key, final boolean value) {
+        return put(key, Boolean.toString(value));
+    }
+
+    synchronized public boolean putInteger(final String key, final Integer value) {
+        return put(key, Integer.toString(value));
+    }
+
+    synchronized public boolean putDouble(final String key, final Double value) {
+        return put(key, Double.toString(value));
     }
 
@@ -343 +353 @@
     }
 
-    // only for compatibility. Don't use any more.
-    @Deprecated
-    public static Color getPreferencesColor(String colName, Color def)
-    {
-        return Main.pref.getColor(colName, def);
-    }
-
     /**
      * Convenience method for accessing colour preferences.
@@ -372 +375 @@
     }
 
-    synchronized public void putColor(String colName, Color val) {
-        put("color."+colName, val != null ? ColorHelper.color2html(val) : null);
+    synchronized public boolean putColor(String colName, Color val) {
+        return put("color."+colName, val != null ? ColorHelper.color2html(val) : null);
     }
 
@@ -431 +434 @@
                 return Arrays.asList(s.split(";"));
         }
-        else if(def != null)
-            return def;
-        return null;
+        return def;
     }
     synchronized public void removeFromCollection(String key, String value) {
@@ -443 +444 @@
         }
     }
-    synchronized public void putCollection(String key, Collection<String> val) {
+    synchronized public boolean putCollection(String key, Collection<String> val) {
         String s = null;
         if(val != null)
@@ -456 +457 @@
         }
 
-        put(key, s);
+        return put(key, s);
     }
 

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -103 +103 @@
             relations.add((Relation) osm);
         }
-    }
-
-    /**
-     * Remove the selection of the whole dataset.
-     * @deprecated Use {@link #setSelected(Collection) setSelected} instead.
-     */
-    @Deprecated public void clearSelection() {
-        clearSelection(nodes);
-        clearSelection(ways);
-        clearSelection(relations);
-        Collection<OsmPrimitive> sel = Collections.emptyList();
-        fireSelectionChanged(sel);
     }
 

trunk/src/org/openstreetmap/josm/data/osm/Way.java

@@ -117 +117 @@
         return name;
     }
-
-    @Deprecated
-    public boolean isIncomplete() {
-        return incomplete;
-    }
 }

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -144 +144 @@
      * handled by the OS are not duplicated on the menu.
      */
-    public static void add(JMenu menu, JosmAction action) {
+    public static JMenuItem add(JMenu menu, JosmAction action) {
+        JMenuItem menuitem = null;
         if (!action.getShortcut().getAutomatic()) {
-            JMenuItem menuitem = menu.add(action);
+            menuitem = menu.add(action);
             KeyStroke ks = action.getShortcut().getKeyStroke();
             if (ks != null) {
@@ -152 +153 @@
             }
         }
+        return menuitem;
     }
 

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -21 +21 @@
 import org.openstreetmap.josm.actions.mapmode.SelectAction;
 import org.openstreetmap.josm.actions.mapmode.ZoomAction;
+import org.openstreetmap.josm.gui.ScrollViewport;
 import org.openstreetmap.josm.gui.dialogs.CommandStackDialog;
 import org.openstreetmap.josm.gui.dialogs.ConflictDialog;
@@ -52 +53 @@
      * instead of adding directly to this list. To add a new mode use addMapMode.
      */
-    public JToolBar toolBarActions = new JToolBar(JToolBar.VERTICAL);
-    public JToolBar toolBarToggle = new JToolBar(JToolBar.VERTICAL);
+    private JToolBar toolBarActions = new JToolBar(JToolBar.VERTICAL);
+    private JToolBar toolBarToggle = new JToolBar(JToolBar.VERTICAL);
     /**
      * The status line below the map
@@ -145 +146 @@
      * @param dlg The toggle dialog. It must not be in the list already.
      */
-    public void addToggleDialog(ToggleDialog dlg) {
+    public IconToggleButton addToggleDialog(ToggleDialog dlg) {
         IconToggleButton button = new IconToggleButton(dlg.action);
         dlg.action.button = button;
@@ -151 +152 @@
         toolBarToggle.add(button);
         toggleDialogs.add(dlg);
+        return button;
     }
 
@@ -197 +199 @@
         jb.addSeparator();
         jb.add(toolBarToggle);
-        panel.add(jb, BorderLayout.WEST);
+        panel.add(new ScrollViewport(jb, ScrollViewport.VERTICAL_DIRECTION),
+        BorderLayout.WEST);
         if (statusLine != null)
             panel.add(statusLine, BorderLayout.SOUTH);

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -57 +57 @@
 
     /**
-     * Interface to notify listeners of the change of the active layer.
-     * @author imi
-     * @deprecated Use Layer.LayerChangeListener instead
-     */
-    @Deprecated public interface LayerChangeListener {
-        void activeLayerChange(Layer oldLayer, Layer newLayer);
-        void layerAdded(Layer newLayer);
-        void layerRemoved(Layer oldLayer);
-    }
-
-    /**
      * A list of all layers currently loaded.
      */
@@ -92 +81 @@
 
     private BufferedImage offscreenBuffer;
-
-    /**
-     * The listener of the active layer changes.
-     * @deprecated Use Layer.listener instead.
-     */
-    @Deprecated private Collection<LayerChangeListener> listeners = new LinkedList<LayerChangeListener>();
 
     public MapView() {
@@ -180 +163 @@
         layers.add(pos, layer);
 
-        // TODO: Deprecated
-        for (LayerChangeListener l : listeners)
-            l.layerAdded(layer);
         for (Layer.LayerChangeListener l : Layer.listeners)
             l.layerAdded(layer);
@@ -214 +194 @@
     public void removeLayer(Layer layer) {
         if (layers.remove(layer)) {
-            // TODO: Deprecated
-            for (LayerChangeListener l : listeners)
-                l.layerRemoved(layer);
             for (Layer.LayerChangeListener l : Layer.listeners)
                 l.layerRemoved(layer);
@@ -347 +324 @@
 
     /**
-     * Add a listener for changes of active layer.
-     * @param listener The listener that get added.
-     * @deprecated Use Layer.listener.add instead.
-     */
-    @Deprecated public void addLayerChangeListener(LayerChangeListener listener) {
-        if (listener != null)
-            listeners.add(listener);
-    }
-
-    /**
-     * Remove the listener.
-     * @param listener The listener that get removed from the list.
-     * @deprecated Use Layer.listener.remove instead
-     */
-    @Deprecated public void removeLayerChangeListener(LayerChangeListener listener) {
-        listeners.remove(listener);
-    }
-
-    /**
      * @return An unmodificable list of all layers
      */
@@ -388 +346 @@
         activeLayer = layer;
         if (old != layer) {
-            // TODO: Deprecated
-            for (LayerChangeListener l : listeners)
-                l.activeLayerChange(old, layer);
             for (Layer.LayerChangeListener l : Layer.listeners)
                 l.activeLayerChange(old, layer);

trunk/src/org/openstreetmap/josm/gui/SideButton.java

@@ -25 +25 @@
         addActionListener(actionListener);
         setToolTipText(tooltip);
-    }
-    @Deprecated
-    public SideButton(String name, String imagename, String property, String tooltip, int mnemonic, ActionListener actionListener)
-    {
-        super(tr(name), ImageProvider.get("dialogs", imagename));
-        setMnemonic(mnemonic);
-        setup(name, property, tooltip, actionListener);
     }
     public SideButton(String name, String imagename, String property, String tooltip, Shortcut shortcut, ActionListener actionListener)

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -61 +61 @@
     public JPanel parent;
     private final JPanel titleBar = new JPanel(new GridBagLayout());
-
-    @Deprecated
-    public ToggleDialog(final String name, String iconName, String tooltip, int shortcut, int preferredHeight) {
-        super(new BorderLayout());
-        this.prefName = iconName;
-        ToggleDialogInit(name, iconName, tooltip, Shortcut.registerShortcut("auto:"+name, tooltip, shortcut, Shortcut.GROUP_LAYER), preferredHeight);
-    }
 
     public ToggleDialog(final String name, String iconName, String tooltip, Shortcut shortcut, int preferredHeight) {

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -104 +104 @@
 
     /**
-     * @deprecated Use Main.main.undoRedo.add(...) instead.
-     */
-    @Deprecated public void add(final Command c) {
-        Main.main.undoRedo.add(c);
-    }
-
-    /**
      * The data behind this layer.
      */

trunk/src/org/openstreetmap/josm/gui/preferences/AdvancedPreference.java

@@ -134 +134 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         for (int i = 0; i < model.getRowCount(); ++i) {
             String value = model.getValueAt(i,1).toString();
@@ -148 +148 @@
         for (Entry<String, String> e : orig.entrySet())
             Main.pref.put(e.getKey(), null);
+        return false;
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/AudioPreference.java

@@ -158 +158 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Main.pref.put("audio.menuinvisible", ! audioMenuVisible.isSelected());
         Main.pref.put("marker.traceaudio", markerAudioTraceVisible.isSelected());
@@ -171 +171 @@
         Main.pref.put("audio.leadin", audioLeadIn.getText());
         Main.pref.put("audio.calibration", audioCalibration.getText());
+        return false;
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/ColorPreference.java

@@ -175 +175 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         for (int i = 0; i < colors.getRowCount(); ++i) {
-            String name = (String)colors.getValueAt(i, 0);
-            Color col = (Color)colors.getValueAt(i, 1);
-            Main.pref.put("color." + name, ColorHelper.color2html(col));
+            Main.pref.putColor((String)colors.getValueAt(i, 0), (Color)colors.getValueAt(i, 1));
         }
         org.openstreetmap.josm.gui.layer.OsmDataLayer.createHatchTexture();
+        return false;
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/DrawingPreference.java

@@ -166 +166 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Main.pref.put("draw.rawgps.lines", drawRawGpsLines.isSelected());
         Main.pref.put("draw.rawgps.max-line-length", drawRawGpsMaxLineLength.getText());
@@ -184 +184 @@
         if(virtualNodes.isSelected()) { if (vn < 1) vn = 8; }
         else { vn = 0; }
-        Main.pref.put("mappaint.node.virtual-size", Integer.toString(vn));
+        Main.pref.putInteger("mappaint.node.virtual-size", vn);
+        return false;
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/FilePreferences.java

@@ -28 +28 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Main.pref.put("save.keepbackup", keepBackup.isSelected());
+        return false;
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/LafPreference.java

@@ -63 +63 @@
             }
         });
-        lafCombo.addActionListener(gui.requireRestartAction);
 
         panel = new JPanel(new GridBagLayout());
@@ -89 +88 @@
     }
 
-    public void ok() {
-        Main.pref.put("laf", ((LookAndFeelInfo)lafCombo.getSelectedItem()).getClassName());
+    public boolean ok() {
         Main.pref.put("draw.splashscreen", showSplashScreen.isSelected());
         Main.pref.put("osm-primitives.showid", showID.isSelected());
+        return Main.pref.put("laf", ((LookAndFeelInfo)lafCombo.getSelectedItem()).getClassName());
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/LanguagePreference.java

@@ -53 +53 @@
             }
         });
-        langCombo.addActionListener(gui.requireRestartAction);
 
         JPanel panel = null;
@@ -67 +66 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         if(langCombo.getSelectedItem() == null)
-        {
-            Main.pref.put("language", null);
-        }
+            return Main.pref.put("language", null);
         else
-        {
-            String l = ((Locale)langCombo.getSelectedItem()).toString();
-            Main.pref.put("language", l);
-        }
+            return Main.pref.put("language",
+            ((Locale)langCombo.getSelectedItem()).toString());
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/MapPaintPreference.java

@@ -10 +10 @@
     }
 
-    public void ok() {
-        // dummy
+    public boolean ok() {
+        return false; // dummy
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/PluginPreference.java

@@ -351 +351 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Collection<PluginDescription> toDownload = new LinkedList<PluginDescription>();
         String msg = "";
@@ -375 +375 @@
         }
 
-        String oldPlugins = Main.pref.get("plugins");
-            LinkedList<String> plugins = new LinkedList<String>();
+        LinkedList<String> plugins = new LinkedList<String>();
         Object pd[] = pluginMap.keySet().toArray();
         Arrays.sort(pd);
@@ -384 +383 @@
         }
 
-        Main.pref.putCollection("plugins", plugins);
-        String newPlugins = Main.pref.get("plugins");
-        if(oldPlugins == null && plugins == null)
-            return;
-        if(plugins == null || oldPlugins == null || !plugins.equals(oldPlugins))
-            gui.requiresRestart = true;
+        return Main.pref.putCollection("plugins", plugins);
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceDialog.java

@@ -35 +35 @@
 
     public final static Collection<PreferenceSetting> settings = new LinkedList<PreferenceSetting>();
-
-    public boolean requiresRestart = false;
-    public final RequireRestartAction requireRestartAction = new RequireRestartAction();
 
     // some common tabs
@@ -91 +88 @@
     }
 
-
-
-    private final class RequireRestartAction implements ActionListener {
-        public void actionPerformed(ActionEvent e) {
-            requiresRestart = true;
+    public void ok() {
+        boolean requiresRestart = false;
+        for (PreferenceSetting setting : settings)
+        {
+            if(setting.ok())
+                requiresRestart = true;
         }
-    }
-
-    public void ok() {
-        for (PreferenceSetting setting : settings)
-            setting.ok();
         if (requiresRestart)
             JOptionPane.showMessageDialog(Main.parent,tr("You have to restart JOSM for some settings to take effect."));

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceSetting.java

@@ -12 +12 @@
     /**
      * Called when OK is pressed to save the setting in the preferences file.
+     * Return true when restart is required.
      */
-    void ok();
+    boolean ok();
 }

trunk/src/org/openstreetmap/josm/gui/preferences/ProjectionPreference.java

@@ -41 +41 @@
         }
 
-        projectionCombo.addActionListener(gui.requireRestartAction);
-        coordinatesCombo.addActionListener(gui.requireRestartAction);
-
         JPanel projPanel = new JPanel();
         projPanel.setBorder(BorderFactory.createTitledBorder(BorderFactory.createLineBorder(Color.gray), tr("Map Projection")));
@@ -56 +53 @@
     }
 
-    public void ok() {
-        Main.pref.put("projection", projectionCombo.getSelectedItem().getClass().getName());
-        Main.pref.put("coordinates", ((CoordinateFormat)coordinatesCombo.getSelectedItem()).name());
+    public boolean ok() {
+        boolean restart = Main.pref.put("projection",
+        projectionCombo.getSelectedItem().getClass().getName());
+        if(Main.pref.put("coordinates",
+        ((CoordinateFormat)coordinatesCombo.getSelectedItem()).name()))
+            restart = true;
+        return restart;
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/ProxyPreferences.java

@@ -78 +78 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Main.pref.put(PROXY_ENABLE, proxyEnable.isSelected());
         Main.pref.put(PROXY_HOST, proxyHost.getText());
@@ -85 +85 @@
         Main.pref.put(PROXY_USER, proxyUser.getText());
         Main.pref.put(PROXY_PASS, new String(proxyPass.getPassword()));
+        return false;
     }
-
 }

trunk/src/org/openstreetmap/josm/gui/preferences/ServerAccessPreference.java

@@ -51 +51 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Main.pref.put("osm-server.url", osmDataServer.getText());
         Main.pref.put("osm-server.username", osmDataUsername.getText());
-        String pwd = String.valueOf(osmDataPassword.getPassword());
-        if (pwd.equals(""))
-            pwd = null;
-        Main.pref.put("osm-server.password", pwd);
+        Main.pref.put("osm-server.password", String.valueOf(osmDataPassword.getPassword()));
+        return false;
     }
 }

trunk/src/org/openstreetmap/josm/gui/preferences/ShortcutPreference.java

@@ -30 +30 @@
     }
 
-    public void ok() {
-   }
+    public boolean ok() {
+        return false;
+    }
 
     // Maybe move this to prefPanel? There's no need for it to be here.
@@ -89 +90 @@
         }
     }
-
 }

trunk/src/org/openstreetmap/josm/gui/preferences/TaggingPresetPreference.java

@@ -8 +8 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
@@ -44 +45 @@
                 Main.pref.getBoolean("taggingpreset.enable-defaults", true));
 
-        String annos = Main.pref.get("taggingpreset.sources");
-        StringTokenizer st = new StringTokenizer(annos, ";");
-        while (st.hasMoreTokens())
-            ((DefaultListModel)taggingPresetSources.getModel()).addElement(st.nextToken());
+        Collection<String> sources = Main.pref.getCollection("taggingpreset.sources", null);
+        if(sources != null)
+            for(String s : sources)
+                ((DefaultListModel)taggingPresetSources.getModel()).addElement(s);
 
         JButton addAnno = new JButton(tr("Add"));
@@ -53 +54 @@
             public void actionPerformed(ActionEvent e) {
                 String source = JOptionPane.showInputDialog(Main.parent, tr("Tagging preset source"));
-                if (source == null)
-                    return;
-                ((DefaultListModel)taggingPresetSources.getModel()).addElement(source);
-                gui.requiresRestart = true;
+                if (source != null)
+                    ((DefaultListModel)taggingPresetSources.getModel()).addElement(source);
             }
         });
@@ -67 +66 @@
                 else {
                     String source = JOptionPane.showInputDialog(Main.parent, tr("Tagging preset source"), taggingPresetSources.getSelectedValue());
-                    if (source == null)
-                        return;
-                    ((DefaultListModel)taggingPresetSources.getModel()).setElementAt(source, taggingPresetSources.getSelectedIndex());
-                    gui.requiresRestart = true;
+                    if (source != null)
+                        ((DefaultListModel)taggingPresetSources.getModel()).setElementAt(source, taggingPresetSources.getSelectedIndex());
                 }
             }
@@ -82 +79 @@
                 else {
                     ((DefaultListModel)taggingPresetSources.getModel()).remove(taggingPresetSources.getSelectedIndex());
-                    gui.requiresRestart = true;
                 }
             }
@@ -107 +103 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         Main.pref.put("taggingpreset.enable-defaults", enableDefault.getSelectedObjects() != null);
-        if (taggingPresetSources.getModel().getSize() > 0) {
-            StringBuilder sb = new StringBuilder();
-            for (int i = 0; i < taggingPresetSources.getModel().getSize(); ++i)
-                sb.append(";"+taggingPresetSources.getModel().getElementAt(i));
-            Main.pref.put("taggingpreset.sources", sb.toString().substring(1));
-        } else
-            Main.pref.put("taggingpreset.sources", null);
+        int num = taggingPresetSources.getModel().getSize();
+        boolean restart;
+        if (num > 0)
+        {
+            ArrayList<String> l = new ArrayList<String>();
+            for (int i = 0; i < num; ++i)
+                l.add((String)taggingPresetSources.getModel().getElementAt(i));
+            restart = Main.pref.putCollection("taggingpreset.sources", l);
+        }
+        else
+            restart = Main.pref.putCollection("taggingpreset.sources", null);
+        return restart;
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -234 +234 @@
     }
 
-    public void ok() {
+    public boolean ok() {
         StringBuilder b = new StringBuilder();
         for (int i = 0; i < selected.size(); ++i) {
@@ -250 +250 @@
         Main.pref.put("toolbar", s);
         refreshToolbarControl();
+        return false;
     }