Changeset 11652 in josm for trunk/src/org/openstreetmap

Timestamp:

2017-03-03T01:40:29+01:00 (8 years ago)

Author:

Don-vip

Message:

FindBugs - ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD

File:

• trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -70 +70 @@
         old = layer.getDisplaySettings().getDisplacement();
         addListeners();
-        offsetDialog = new ImageryOffsetDialog();
+        showOffsetDialog(new ImageryOffsetDialog());
+    }
+
+    private static void showOffsetDialog(ImageryOffsetDialog dlg) {
+        offsetDialog = dlg;
         offsetDialog.setVisible(true);
+    }
+
+    private static void hideOffsetDialog() {
+        offsetDialog.setVisible(false);
+        offsetDialog = null;
     }
 
@@ -91 +100 @@
                 layer.getDisplaySettings().setDisplacement(old);
             }
-            offsetDialog.setVisible(false);
+            hideOffsetDialog();
             // do not restore old mode here - this is called when the new mode is already known.
-            offsetDialog = null;
         }
         removeListeners();