Changeset 11635 in josm for trunk

Timestamp:

2017-02-26T13:44:47+01:00 (7 years ago)

Author:

Don-vip

Message:

see #12313 - fix unit tests properly

Location:

trunk

Files:

• src/org/openstreetmap/josm/actions/AddImageryLayerAction.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/actions/AddImageryLayerActionTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java

@@ -67 +67 @@
         putValue("toolbar", "imagery_" + info.getToolbarName());
         putValue("help", ht("/Preferences/Imagery"));
-        String tooltip = info.getToolTipText();
-        if (tooltip != null) {
-            setTooltip(tooltip.replaceAll("</?html>", ""));
-        }
+        setTooltip(info.getToolTipText().replaceAll("</?html>", ""));
         this.info = info;
         installAdapters();

trunk/test/unit/org/openstreetmap/josm/actions/AddImageryLayerActionTest.java

@@ -35 +35 @@
     @Test
     public void testEnabledState() {
-        assertTrue(new AddImageryLayerAction(new ImageryInfo()).isEnabled());
+        assertTrue(new AddImageryLayerAction(new ImageryInfo("foo")).isEnabled());
         assertTrue(new AddImageryLayerAction(new ImageryInfo("foo_tms", "http://bar", "tms", null, null)).isEnabled());
         assertTrue(new AddImageryLayerAction(new ImageryInfo("foo_bing", "http://bar", "bing", null, null)).isEnabled());
@@ -71 +71 @@
         assertTrue(Main.getLayerManager().getLayersOfType(TMSLayer.class).isEmpty());
         try {
-            new AddImageryLayerAction(new ImageryInfo()).actionPerformed(null);
+            new AddImageryLayerAction(new ImageryInfo("foo")).actionPerformed(null);
         } catch (IllegalArgumentException expected) {
             assertEquals("Parameter 'info.url' must not be null", expected.getMessage());