Changeset 11604 in josm for trunk/src/org


Ignore:
Timestamp:
2017-02-23T23:44:29+01:00 (3 years ago)
Author:
Don-vip
Message:

sonar - squid:S1172 - Unused method parameters should be removed

Location:
trunk/src/org/openstreetmap/josm/gui
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/gui/conflict/pair/AbstractListMerger.java

    r11331 r11604  
    829829    }
    830830
    831     protected void handlePropertyChangeFrozen(boolean oldValue, boolean newValue) {
     831    protected void handlePropertyChangeFrozen(boolean newValue) {
    832832        myEntriesTable.getSelectionModel().clearSelection();
    833833        myEntriesTable.setEnabled(!newValue);
     
    853853    public void propertyChange(PropertyChangeEvent evt) {
    854854        if (evt.getPropertyName().equals(AbstractListMergeModel.FROZEN_PROP)) {
    855             handlePropertyChangeFrozen((Boolean) evt.getOldValue(), (Boolean) evt.getNewValue());
     855            handlePropertyChangeFrozen((Boolean) evt.getNewValue());
    856856        }
    857857    }
  • trunk/src/org/openstreetmap/josm/gui/io/UploadLayerTask.java

    r11553 r11604  
    8383     *
    8484     * @param e the exception throw by the API
    85      * @param monitor a progress monitor
    8685     * @throws OsmTransferException if we can't recover from the exception
    8786     */
    88     protected void recoverFromGoneOnServer(OsmApiPrimitiveGoneException e, ProgressMonitor monitor) throws OsmTransferException {
     87    protected void recoverFromGoneOnServer(OsmApiPrimitiveGoneException e) throws OsmTransferException {
    8988        if (!e.isKnownPrimitive()) throw e;
    9089        OsmPrimitive p = getPrimitive(e.getPrimitiveType(), e.getPrimitiveId());
     
    127126                    break;
    128127                } catch (OsmApiPrimitiveGoneException e) {
    129                     recoverFromGoneOnServer(e, monitor);
     128                    recoverFromGoneOnServer(e);
    130129                }
    131130            }
  • trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java

    r11545 r11604  
    279279     * If the current tileLoader is an instance of OsmTileLoader, a new
    280280     * TmsTileClearController is created and passed to the according clearCache method.
    281      *
    282      * @param monitor not used in this implementation - as cache clear is instaneus
    283      */
    284     public void clearTileCache(ProgressMonitor monitor) {
     281     */
     282    public void clearTileCache() {
    285283        if (tileLoader instanceof CachedTileLoader) {
    286284            ((CachedTileLoader) tileLoader).clearCache(tileSource);
     
    621619                @Override
    622620                protected void realRun() {
    623                     clearTileCache(getProgressMonitor());
     621                    clearTileCache();
    624622                }
    625623
  • trunk/src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUI.java

    r10938 r11604  
    414414        }
    415415
    416         protected void alertAuthorisationFailed(OsmOAuthAuthorizationException e) {
     416        protected void alertAuthorisationFailed() {
    417417            HelpAwareOptionPane.showOptionDialog(
    418418                    FullyAutomaticAuthorizationUI.this,
     
    445445        }
    446446
    447         protected void alertLoginFailed(OsmLoginFailedException e) {
     447        protected void alertLoginFailed() {
    448448            final String loginUrl = getAdvancedPropertiesPanel().getAdvancedParameters().getOsmLoginUrl();
    449449            HelpAwareOptionPane.showOptionDialog(
     
    466466            Runnable r = () -> {
    467467                if (e instanceof OsmLoginFailedException) {
    468                     alertLoginFailed((OsmLoginFailedException) e);
     468                    alertLoginFailed();
    469469                } else {
    470                     alertAuthorisationFailed(e);
     470                    alertAuthorisationFailed();
    471471                }
    472472            };
  • trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveAccessTokenTask.java

    r10627 r11604  
    6666    protected void finish() { /* not used in this task */}
    6767
    68     protected void alertRetrievingAccessTokenFailed(OsmOAuthAuthorizationException e) {
     68    protected void alertRetrievingAccessTokenFailed() {
    6969        HelpAwareOptionPane.showOptionDialog(
    7070                parent,
     
    9191        } catch (final OsmOAuthAuthorizationException e) {
    9292            Main.error(e);
    93             GuiHelper.runInEDT(() -> alertRetrievingAccessTokenFailed(e));
     93            GuiHelper.runInEDT(this::alertRetrievingAccessTokenFailed);
    9494            accessToken = null;
    9595        } finally {
  • trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveRequestTokenTask.java

    r10627 r11604  
    6060    protected void finish() { /* not used in this task */}
    6161
    62     protected void alertRetrievingRequestTokenFailed(OsmOAuthAuthorizationException e) {
     62    protected void alertRetrievingRequestTokenFailed() {
    6363        HelpAwareOptionPane.showOptionDialog(
    6464                parent,
     
    8585        } catch (final OsmOAuthAuthorizationException e) {
    8686            Main.error(e);
    87             GuiHelper.runInEDT(() -> alertRetrievingRequestTokenFailed(e));
     87            GuiHelper.runInEDT(this::alertRetrievingRequestTokenFailed);
    8888            requestToken = null;
    8989        } finally {
Note: See TracChangeset for help on using the changeset viewer.