Changeset 11567 in josm for trunk/src/org

Timestamp:

2017-02-14T23:48:53+01:00 (7 years ago)

Author:

Don-vip

Message:

findbugs - PZLA_PREFER_ZERO_LENGTH_ARRAYS

Location:

trunk/src/org/openstreetmap/josm/io/remotecontrol

Files:

• RequestProcessor.java (modified) (1 diff)
• handler/FeaturesHandler.java (modified) (1 diff)
• handler/RequestHandler.java (modified) (2 diffs)
• handler/VersionHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/remotecontrol/RequestProcessor.java

@@ -475 +475 @@
                 usage.append(" &mdash; <i>").append(sample.getUsage()).append("</i>");
             }
-            if (mandatory != null) {
+            if (mandatory != null && mandatory.length > 0) {
                 usage.append("<br/>mandatory parameters: ").append(Utils.join(", ", Arrays.asList(mandatory)));
             }
-            if (optional != null) {
+            if (optional != null && optional.length > 0) {
                 usage.append("<br/>optional parameters: ").append(Utils.join(", ", Arrays.asList(optional)));
             }
-            if (examples != null) {
+            if (examples != null && examples.length > 0) {
                 usage.append("<br/>examples: ");
                 for (String ex: examples) {

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/FeaturesHandler.java

@@ -64 +64 @@
     @Override
     public String[] getMandatoryParams() {
-        return null;
+        return new String[0];
     }
 

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandler.java

@@ -111 +111 @@
 
     public String[] getOptionalParams() {
-        return null;
+        return new String[0];
     }
 
@@ -119 +119 @@
 
     public String[] getUsageExamples() {
-        return null;
+        return new String[0];
     }
 

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/VersionHandler.java

@@ -39 +39 @@
     @Override
     public String[] getMandatoryParams() {
-        return null;
+        return new String[0];
     }