Changeset 11538 in josm

Timestamp:

2017-02-04T15:39:06+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:ISB_TOSTRING_APPENDING - Correctness - Method concatenates the result of a toString() call

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/JosmAction.java (modified) (3 diffs)
• gui/dialogs/ToggleDialog.java (modified) (1 diff)
• tools/Pair.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/JosmAction.java

@@ -356 +356 @@
         @Override
         public String toString() {
-            return "LayerChangeAdapter [" + JosmAction.this.toString() + ']';
+            return "LayerChangeAdapter [" + JosmAction.this + ']';
         }
     }
@@ -371 +371 @@
         @Override
         public String toString() {
-            return "ActiveLayerChangeAdapter [" + JosmAction.this.toString() + ']';
+            return "ActiveLayerChangeAdapter [" + JosmAction.this + ']';
         }
     }
@@ -386 +386 @@
         @Override
         public String toString() {
-            return "SelectionChangeAdapter [" + JosmAction.this.toString() + ']';
+            return "SelectionChangeAdapter [" + JosmAction.this + ']';
         }
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -312 +312 @@
         @Override
         public String toString() {
-            return "ToggleDialogAction [" + ToggleDialog.this.toString() + ']';
+            return "ToggleDialogAction [" + ToggleDialog.this + ']';
         }
     }

trunk/src/org/openstreetmap/josm/tools/Pair.java

@@ -62 +62 @@
     @Override
     public String toString() {
-        return '<'+a.toString()+','+b.toString()+'>';
+        return "<" + a + ',' + b + '>';
     }