Changeset 11536 in josm

Timestamp:

2017-02-04T15:26:23+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:WOC_WRITE_ONLY_COLLECTION_FIELD - Correctness - Class creates and initializes a collection but never reads or gains information from it

File:

• trunk/src/org/openstreetmap/josm/gui/MapFrame.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -119 +119 @@
 
     private final List<ToggleDialog> allDialogs = new ArrayList<>();
-    private final List<MapMode> mapModes = new ArrayList<>();
     private final List<IconToggleButton> allDialogButtons = new ArrayList<>();
     public final List<IconToggleButton> allMapModeButtons = new ArrayList<>();
@@ -388 +387 @@
 
     public void addMapMode(IconToggleButton b) {
-        if (b.getAction() instanceof MapMode) {
-            mapModes.add((MapMode) b.getAction());
-        } else
+        if (!(b.getAction() instanceof MapMode))
             throw new IllegalArgumentException("MapMode action must be subclass of MapMode");
         allMapModeButtons.add(b);