Changeset 11519 in josm for trunk/src/org

Timestamp:

2017-01-31T23:27:09+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:PDP_POORLY_DEFINED_PARAMETER - Correctness - Method defines parameters more abstractly than needed to function properly

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• history/NodeListViewer.java (modified) (4 diffs)
• layer/JumpToMarkerActions.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/history/NodeListViewer.java

@@ -20 +20 @@
 import javax.swing.event.TableModelEvent;
 import javax.swing.event.TableModelListener;
-import javax.swing.table.TableModel;
 
 import org.openstreetmap.josm.Main;
@@ -318 +317 @@
     }
 
-    private static PrimitiveId primitiveIdAtRow(TableModel model, int row) {
-        DiffTableModel castedModel = (DiffTableModel) model;
-        Long id = (Long) castedModel.getValueAt(row, 0).value;
+    private static PrimitiveId primitiveIdAtRow(DiffTableModel model, int row) {
+        Long id = (Long) model.getValueAt(row, 0).value;
         return id == null ? null : new SimplePrimitiveId(id, OsmPrimitiveType.NODE);
     }
@@ -332 +330 @@
         protected int checkTableSelection(JTable table, Point p) {
             int row = super.checkTableSelection(table, p);
-            popupMenu.prepare(primitiveIdAtRow(table.getModel(), row));
+            popupMenu.prepare(primitiveIdAtRow((DiffTableModel) table.getModel(), row));
             return row;
         }
@@ -353 +351 @@
             if (row <= 0)
                 return;
-            PrimitiveId pid = primitiveIdAtRow(table.getModel(), row);
+            PrimitiveId pid = primitiveIdAtRow((DiffTableModel) table.getModel(), row);
             if (pid == null || pid.isNew())
                 return;

trunk/src/org/openstreetmap/josm/gui/layer/JumpToMarkerActions.java

@@ -45 +45 @@
     private abstract static class JumpToMarker extends AbstractAction implements MultikeyShortcutAction {
 
-        private final transient Layer layer;
+        private final transient JumpToMarkerLayer layer;
         private final transient Shortcut multikeyShortcut;
         private transient WeakReference<Layer> lastLayer;
 
         JumpToMarker(JumpToMarkerLayer layer, Shortcut shortcut) {
-            this.layer = (Layer) layer;
+            this.layer = layer;
             this.multikeyShortcut = shortcut;
             this.multikeyShortcut.setAccelerator(this);
@@ -74 +74 @@
             if (l != null) {
                 if (l instanceof JumpToMarkerLayer) {
-                    execute(l);
+                    execute((JumpToMarkerLayer) l);
                 }
             } else if (repeat && lastLayer != null) {
                 l = lastLayer.get();
-                if (LayerListDialog.isLayerValid(l)) {
-                    execute(l);
+                if (LayerListDialog.isLayerValid(l) && l instanceof JumpToMarkerLayer) {
+                    execute((JumpToMarkerLayer) l);
                 }
             }
         }
 
-        protected abstract void execute(Layer l);
+        protected abstract void execute(JumpToMarkerLayer l);
 
         @Override
@@ -110 +110 @@
 
         @Override
-        protected void execute(Layer l) {
-            ((JumpToMarkerLayer) l).jumpToNextMarker();
-            setLastLayer(l);
+        protected void execute(JumpToMarkerLayer l) {
+            l.jumpToNextMarker();
+            setLastLayer((Layer) l);
         }
     }
@@ -126 +126 @@
 
         @Override
-        protected void execute(Layer l) {
-            ((JumpToMarkerLayer) l).jumpToPreviousMarker();
-            setLastLayer(l);
+        protected void execute(JumpToMarkerLayer l) {
+            l.jumpToPreviousMarker();
+            setLastLayer((Layer) l);
         }
     }