Changeset 11461 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2017-01-12T02:36:14+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:SPP_USE_CONTAINSKEY - Style - Method calls keySet() just to call contains, use containsKey instead

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• dialogs/relation/RelationDialogManager.java (modified) (1 diff)
• history/HistoryBrowserDialogManager.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/RelationDialogManager.java

@@ -150 +150 @@
         if (relation == null) return false;
         DialogContext context = new DialogContext(layer, relation);
-        return openDialogs.keySet().contains(context);
-
+        return openDialogs.containsKey(context);
     }
 

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java

@@ -88 +88 @@
 
     private void show(long id, HistoryBrowserDialog dialog) {
-        if (dialogs.values().contains(dialog)) {
+        if (dialogs.containsValue(dialog)) {
             show(id);
         } else {
@@ -98 +98 @@
 
     private void show(long id) {
-        if (dialogs.keySet().contains(id)) {
+        if (dialogs.containsKey(id)) {
             dialogs.get(id).toFront();
         }