Changeset 11392 in josm

Timestamp:

2016-12-14T00:52:36+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S1206 - "equals(Object obj)" and "hashCode()" should be overridden in pairs (required equalsverifier 2.1.8)

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/osm/Storage.java (modified) (5 diffs)
• test/unit/org/openstreetmap/josm/data/osm/StorageTest.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/osm/Storage.java

@@ -3 +3 @@
 
 import java.util.AbstractSet;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.ConcurrentModificationException;
@@ -239 +240 @@
     public synchronized int hashCode() {
         int h = 0;
-        for (T t : this) {
-            h += hash.getHashCode(t);
+        if (hash != null) {
+            for (T t : this) {
+                h += hash.getHashCode(t);
+            }
         }
         return h;
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        if (this == obj)
+            return true;
+        if (obj == null || getClass() != obj.getClass())
+            return false;
+        Storage<?> other = (Storage<?>) obj;
+        return Arrays.equals(data, other.data)
+                && hashCode() == obj.hashCode();
     }
 
@@ -321 +335 @@
         int hcode = rehash(ha.getHashCode(key));
         int bucket = hcode & mask;
-        while ((entry = data[bucket]) != null) {
+        while (bucket < data.length && (entry = data[bucket]) != null) {
             if (ha.equals(key, entry))
                 return bucket;
@@ -500 +514 @@
         @Override
         public boolean hasNext() {
+            if (data == null) return false;
             align();
             return slot < data.length;
@@ -533 +548 @@
         @Override
         public boolean hasNext() {
+            if (data == null) return false;
             align();
             return slot < data.length;

trunk/test/unit/org/openstreetmap/josm/data/osm/StorageTest.java

@@ -2 +2 @@
 package org.openstreetmap.josm.data.osm;
 
-import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
@@ -9 +8 @@
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
 
 /**
@@ -26 +26 @@
      */
     @Test
-    @Ignore("not ready")
     public void testEqualsContract() {
         EqualsVerifier.forClass(Storage.class).usingGetClass()
-            /*.withPrefabValues(Collection.class, new HashSet<>(Arrays.asList(1)), new HashSet<>(Arrays.asList(2)))
-            .withPrefabValues(AbstractCollection.class, new HashSet<>(Arrays.asList(1)), new HashSet<>(Arrays.asList(2)))
-            .withPrefabValues(Set.class, new HashSet<>(Arrays.asList(1)), new HashSet<>(Arrays.asList(2)))
-            .withPrefabValues(AbstractSet.class, new HashSet<>(Arrays.asList(1)), new HashSet<>(Arrays.asList(2)))*/
+            .suppress(Warning.NONFINAL_FIELDS)
+            .withIgnoredFields("arrayCopyNecessary", "hash", "mask", "modCount", "safeIterator", "size")
             .withPrefabValues(Hash.class, Storage.<Integer>defaultHash(), Storage.<Boolean>defaultHash())
             .verify();