Changeset 11316 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-11-26T12:47:04+01:00 (7 years ago)

Author:

Don-vip

Message:

findbugs - SA_FIELD_DOUBLE_ASSIGNMENT - proper fix

File:

• trunk/src/org/openstreetmap/josm/data/osm/Relation.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/osm/Relation.java

@@ -451 +451 @@
         addToBBox(box, new HashSet<PrimitiveId>());
         if (getDataSet() != null)
-            bbox = box; // set cache
+            setBBox(box); // set cache
         return new BBox(box);
+    }
+
+    private void setBBox(BBox bbox) {
+        this.bbox = bbox;
     }
 
@@ -465 +469 @@
     @Override
     public void updatePosition() {
-        bbox = getBBox();
+        setBBox(null); // make sure that it is recalculated
+        setBBox(getBBox());
     }
 
@@ -472 +477 @@
         super.setDataset(dataSet);
         checkMembers();
-        bbox = null; // bbox might have changed if relation was in ds, was removed, modified, added back to dataset
+        setBBox(null); // bbox might have changed if relation was in ds, was removed, modified, added back to dataset
     }