Changeset 11294 in josm

Timestamp:

2016-11-22T16:07:59+01:00 (8 years ago)

Author:

simon04

Message:

Fix ​http://errorprone.info/bugpattern/NarrowingCompoundAssignment

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/AbstractPrimitive.java (modified) (5 diffs)
• data/osm/OsmPrimitive.java (modified) (9 diffs)
• data/osm/visitor/paint/StyledMapRenderer.java (modified) (1 diff)
• tools/MultiLineFlowLayout.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -57 +57 @@
      * and on upload the object will be send to the server.
      */
-    protected static final int FLAG_MODIFIED = 1 << 0;
+    protected static final short FLAG_MODIFIED = 1 << 0;
 
     /**
@@ -63 +63 @@
      * as deleted on the server.
      */
-    protected static final int FLAG_VISIBLE = 1 << 1;
+    protected static final short FLAG_VISIBLE = 1 << 1;
 
     /**
@@ -72 +72 @@
      * objects still referring to it.
      */
-    protected static final int FLAG_DELETED = 1 << 2;
+    protected static final short FLAG_DELETED = 1 << 2;
 
     /**
@@ -79 +79 @@
      * fetched from the server.
      */
-    protected static final int FLAG_INCOMPLETE = 1 << 3;
+    protected static final short FLAG_INCOMPLETE = 1 << 3;
 
     /**
@@ -277 +277 @@
     /* ------*/
 
-    protected void updateFlags(int flag, boolean value) {
+    protected void updateFlags(short flag, boolean value) {
         if (value) {
             flags |= flag;
         } else {
-            flags &= ~flag;
+            flags &= (short) ~flag;
         }
     }

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -52 +52 @@
      * while the filter is active.
      */
-    protected static final int FLAG_DISABLED = 1 << 4;
+    protected static final short FLAG_DISABLED = 1 << 4;
 
     /**
@@ -63 +63 @@
      * unset as well (for efficient access).
      */
-    protected static final int FLAG_HIDE_IF_DISABLED = 1 << 5;
+    protected static final short FLAG_HIDE_IF_DISABLED = 1 << 5;
 
     /**
      * Flag used internally by the filter mechanism.
      */
-    protected static final int FLAG_DISABLED_TYPE = 1 << 6;
+    protected static final short FLAG_DISABLED_TYPE = 1 << 6;
 
     /**
      * Flag used internally by the filter mechanism.
      */
-    protected static final int FLAG_HIDDEN_TYPE = 1 << 7;
+    protected static final short FLAG_HIDDEN_TYPE = 1 << 7;
 
     /**
@@ -80 +80 @@
      * (e.g. one way street.)
      */
-    protected static final int FLAG_HAS_DIRECTIONS = 1 << 8;
+    protected static final short FLAG_HAS_DIRECTIONS = 1 << 8;
 
     /**
@@ -86 +86 @@
      * Some trivial tags like source=* are ignored here.
      */
-    protected static final int FLAG_TAGGED = 1 << 9;
+    protected static final short FLAG_TAGGED = 1 << 9;
 
     /**
@@ -93 +93 @@
      * (E.g. oneway=-1.)
      */
-    protected static final int FLAG_DIRECTION_REVERSED = 1 << 10;
+    protected static final short FLAG_DIRECTION_REVERSED = 1 << 10;
 
     /**
@@ -100 +100 @@
      * that the primitive is currently highlighted.
      */
-    protected static final int FLAG_HIGHLIGHTED = 1 << 11;
+    protected static final short FLAG_HIGHLIGHTED = 1 << 11;
 
     /**
@@ -106 +106 @@
      * Match the "work in progress" tags in default map style.
      */
-    protected static final int FLAG_ANNOTATED = 1 << 12;
+    protected static final short FLAG_ANNOTATED = 1 << 12;
 
     /**
@@ -396 +396 @@
     /* ------*/
 
-    private void updateFlagsNoLock(int flag, boolean value) {
+    private void updateFlagsNoLock(short flag, boolean value) {
         super.updateFlags(flag, value);
     }
 
     @Override
-    protected final void updateFlags(int flag, boolean value) {
+    protected final void updateFlags(short flag, boolean value) {
         boolean locked = writeLock();
         try {
@@ -440 +440 @@
         try {
             int oldFlags = flags;
-            updateFlagsNoLock(FLAG_DISABLED + FLAG_HIDE_IF_DISABLED, false);
+            updateFlagsNoLock(FLAG_DISABLED, false);
+            updateFlagsNoLock(FLAG_HIDE_IF_DISABLED, false);
             return oldFlags != flags;
         } finally {

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -806 +806 @@
             LineMetrics metrics = text.font.getLineMetrics(s, frc);
             if (bs.vAlign == VerticalTextAlignment.ABOVE) {
-                y -= -box.y + metrics.getDescent();
+                y -= -box.y + (int) metrics.getDescent();
             } else if (bs.vAlign == VerticalTextAlignment.TOP) {
-                y -= -box.y - metrics.getAscent();
+                y -= -box.y - (int) metrics.getAscent();
             } else if (bs.vAlign == VerticalTextAlignment.CENTER) {
-                y += (metrics.getAscent() - metrics.getDescent()) / 2;
+                y += (int) ((metrics.getAscent() - metrics.getDescent()) / 2);
             } else if (bs.vAlign == VerticalTextAlignment.BELOW) {
-                y += box.y + box.height + metrics.getAscent() + 2;
+                y += box.y + box.height + (int) metrics.getAscent() + 2;
             } else throw new AssertionError();
         }

trunk/src/org/openstreetmap/josm/tools/MultiLineFlowLayout.java

@@ -75 +75 @@
                     x += getHgap();
                 }
-                x += size.getWidth();
+                x += size.width;
                 if (x > containerWidth) {
                     totalHeight += rowHeight + getVgap();