Changeset 11207 in josm

Timestamp:

2016-11-01T20:14:16+01:00 (7 years ago)

Author:

simon04

Message:

fix #13808 see #12030 - Custom system shortcuts are broken

File:

• trunk/src/org/openstreetmap/josm/tools/Shortcut.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/tools/Shortcut.java

@@ -7 +7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Collection;
 import java.util.Comparator;
 import java.util.HashMap;
@@ -272 +271 @@
 
     // here we store our shortcuts
-    private static Collection<Shortcut> shortcuts = new CopyOnWriteArrayList<Shortcut>() {
+    private static ShortcutCollection shortcuts = new ShortcutCollection();
+
+    private static class ShortcutCollection extends CopyOnWriteArrayList<Shortcut> {
         @Override
         public boolean add(Shortcut shortcut) {
@@ -281 +282 @@
             }
             return super.add(shortcut);
+        }
+
+        public void replace(Shortcut newShortcut) {
+            final Optional<Shortcut> existing = findShortcutByKeyOrShortText(-1, NONE, newShortcut.shortText);
+            if (existing.isPresent()) {
+                replaceAll(sc -> existing.get() == sc ? newShortcut : sc);
+            } else {
+                add(newShortcut);
+            }
         }
     };
@@ -369 +379 @@
                 .filter(sc -> !findShortcut(sc.getAssignedKey(), sc.getAssignedModifier()).isPresent())
                 .sorted(Comparator.comparing(sc -> sc.isAssignedUser() ? 1 : sc.isAssignedDefault() ? 2 : 3))
-                .forEachOrdered(shortcuts::add);
+                .forEachOrdered(shortcuts::replace);
     }