Changeset 11058 in josm for trunk

Timestamp:

2016-09-27T09:27:42+02:00 (8 years ago)

Author:

simon04

Message:

fix #13581 - Preferences: migrate old color keys

File:

• trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -18 +18 @@
 import java.lang.reflect.Field;
 import java.nio.charset.StandardCharsets;
+import java.util.AbstractMap;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -38 +39 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
+import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
@@ -1526 +1528 @@
                 "validator.org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker.entries",
                 "resource://data/validator/power.mapcss");
+        // drop in March 2017
+        if (loadedVersion < 11058) {
+            migrateOldColorKeys();
+        }
 
         for (String key : OBSOLETE_PREF_KEYS) {
@@ -1533 +1539 @@
             }
         }
+    }
+
+    private void migrateOldColorKeys() {
+        settingsMap.keySet().stream()
+                .filter(key -> key.startsWith("color."))
+                .flatMap(key -> {
+                    final String newKey = ColorProperty.getColorKey(key.substring("color.".length()));
+                    return key.equals(newKey) || settingsMap.containsKey(newKey)
+                            ? Stream.empty()
+                            : Stream.of(new AbstractMap.SimpleImmutableEntry<>(key, newKey));
+                })
+                .collect(Collectors.toList()) // to avoid ConcurrentModificationException
+                .forEach(entry -> {
+                    final String oldKey = entry.getKey();
+                    final String newKey = entry.getValue();
+                    Main.info("Migrating old color key {0} => {1}", oldKey, newKey);
+                    put(newKey, get(oldKey));
+                    put(oldKey, null);
+                });
     }