Changeset 11057 in josm

Timestamp:

2016-09-27T09:25:46+02:00 (8 years ago)

Author:

simon04

Message:

Template engine: fix string representations

Location:

trunk

Files:

• src/org/openstreetmap/josm/tools/template_engine/Condition.java (modified) (2 diffs)
• src/org/openstreetmap/josm/tools/template_engine/Variable.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/tools/template_engine/TemplateParserTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/template_engine/Condition.java

@@ -41 +41 @@
     public String toString() {
         StringBuilder sb = new StringBuilder();
-        sb.append("?{");
+        sb.append("?{ ");
         for (TemplateEntry entry: entries) {
             if (entry instanceof SearchExpressionCondition) {
@@ -48 +48 @@
                 sb.append('\'').append(entry).append('\'');
             }
-            sb.append('|');
+            sb.append(" | ");
         }
+        sb.setLength(sb.length() - 3);
+        sb.append(" }");
         return sb.toString();
     }

trunk/src/org/openstreetmap/josm/tools/template_engine/Variable.java

@@ -56 +56 @@
     @Override
     public String toString() {
-        return '{' + variableName + '}';
+        return '{' + (special ? SPECIAL_VARIABLE_PREFIX : "") + variableName + '}';
     }
 

trunk/test/unit/org/openstreetmap/josm/tools/template_engine/TemplateParserTest.java

@@ -174 +174 @@
         entry.appendText(sb, dataProvider);
         Assert.assertEquals("name=waypointName, number=10", sb.toString());
+        Assert.assertEquals("{special:everything}", entry.toString());
     }
 
@@ -333 +334 @@
         Assert.assertEquals("child2", sb.toString());
     }
+
+    @Test
+    public void testToStringCanBeParsedAgain() throws Exception {
+        final String s1 = "?{ '{name} ({desc})' | '{name} ({cmt})' | '{name}' | '{desc}' | '{cmt}' }";
+        final String s2 = new TemplateParser(s1).parse().toString();
+        final String s3 = new TemplateParser(s2).parse().toString();
+        Assert.assertEquals(s1, s2);
+        Assert.assertEquals(s2, s3);
+    }
 }