Changeset 10958 in josm

Timestamp:

2016-09-04T17:27:29+02:00 (8 years ago)

Author:

Don-vip

Message:

fix #13479 - safer management of listeners

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictResolutionDialog.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictResolutionDialog.java

@@ -36 +36 @@
 
     private final ApplyResolutionAction applyResolutionAction = new ApplyResolutionAction();
+
+    private boolean isRegistered;
 
     /**
@@ -65 +67 @@
     }
 
-    private void registerListeners() {
-        resolver.addPropertyChangeListener(applyResolutionAction);
-        resolver.registerListeners();
-    }
-
-    private void unregisterListeners() {
-        resolver.removePropertyChangeListener(applyResolutionAction);
-        resolver.unregisterListeners();
+    private synchronized void registerListeners() {
+        if (!isRegistered) {
+            resolver.addPropertyChangeListener(applyResolutionAction);
+            resolver.registerListeners();
+            isRegistered = true;
+        }
+    }
+
+    private synchronized void unregisterListeners() {
+        // See #13479 - See https://bugs.openjdk.java.net/browse/JDK-4387314
+        // Owner window keep a list of owned windows, and does not remove the references when the child is disposed.
+        // There's no easy way to remove ourselves from this list, so we must keep track of register state
+        if (isRegistered) {
+            resolver.removePropertyChangeListener(applyResolutionAction);
+            resolver.unregisterListeners();
+            isRegistered = false;
+        }
     }