Changeset 10939 in josm for trunk


Ignore:
Timestamp:
2016-09-03T12:42:28+02:00 (3 years ago)
Author:
Don-vip
Message:

sonar - pmd:ImmutableField - Immutable Field

Location:
trunk/src/org/openstreetmap/josm
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/data/preferences/AbstractProperty.java

    r10824 r10939  
    1414
    1515    private final class PreferenceChangedListenerAdapter implements PreferenceChangedListener {
    16         private ValueChangeListener<? super T> listener;
     16        private final ValueChangeListener<? super T> listener;
    1717
    1818        PreferenceChangedListenerAdapter(ValueChangeListener<? super T> listener) {
  • trunk/src/org/openstreetmap/josm/data/preferences/AbstractToStringProperty.java

    r10824 r10939  
    2525     */
    2626    public static class ChildProperty<T> extends AbstractToStringProperty<T> {
    27         private AbstractToStringProperty<T> parent;
     27        private final AbstractToStringProperty<T> parent;
    2828
    2929        ChildProperty(AbstractToStringProperty<T> parent, String key) {
  • trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java

    r10737 r10939  
    2222    private transient TagCollection tags;
    2323    private List<String> displayedKeys;
    24     private Set<String> keysWithConflicts = new HashSet<>();
     24    private final Set<String> keysWithConflicts = new HashSet<>();
    2525    private transient Map<String, MultiValueResolutionDecision> decisions;
    2626    private int numConflicts;
  • trunk/src/org/openstreetmap/josm/gui/layer/imagery/TileCoordinateConverter.java

    r10805 r10939  
    2323    private MapView mapView;
    2424    private TileSourceDisplaySettings settings;
    25     private TileSource tileSource;
     25    private final TileSource tileSource;
    2626
    2727    /**
  • trunk/src/org/openstreetmap/josm/tools/ListenerList.java

    r10936 r10939  
    3535    private static final class WeakListener<T> {
    3636
    37         private WeakReference<T> listener;
     37        private final WeakReference<T> listener;
    3838
    3939        WeakListener(T listener) {
     
    6262        @Override
    6363        public String toString() {
    64             return "WeakListener [listener=" + listener + "]";
     64            return "WeakListener [listener=" + listener + ']';
    6565        }
    6666    }
     
    165165     */
    166166    public static class TracingListenerList<T> extends ListenerList<T> {
    167         private HashMap<T, StackTraceElement[]> listenersAdded = new HashMap<>();
    168         private HashMap<T, StackTraceElement[]> listenersRemoved = new HashMap<>();
     167        private final HashMap<T, StackTraceElement[]> listenersAdded = new HashMap<>();
     168        private final HashMap<T, StackTraceElement[]> listenersRemoved = new HashMap<>();
    169169
    170170        protected TracingListenerList() {
  • trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportQueue.java

    r10886 r10939  
    2020    private static final BugReportQueue INSTANCE = new BugReportQueue();
    2121
    22     private LinkedList<ReportedException> reportsToDisplay = new LinkedList<>();
     22    private final LinkedList<ReportedException> reportsToDisplay = new LinkedList<>();
    2323    private boolean suppressAllMessages;
    24     private ArrayList<ReportedException> suppressFor = new ArrayList<>();
     24    private final ArrayList<ReportedException> suppressFor = new ArrayList<>();
    2525    private Thread displayThread;
    2626    private final BiFunction<ReportedException, Integer, SuppressionMode> bugReportHandler = getBestHandler();
Note: See TracChangeset for help on using the changeset viewer.