Changeset 10939 in josm

Timestamp:

2016-09-03T12:42:28+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - pmd:ImmutableField - Immutable Field

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/preferences/AbstractProperty.java (modified) (1 diff)
• data/preferences/AbstractToStringProperty.java (modified) (1 diff)
• gui/conflict/tags/TagConflictResolverModel.java (modified) (1 diff)
• gui/layer/imagery/TileCoordinateConverter.java (modified) (1 diff)
• tools/ListenerList.java (modified) (3 diffs)
• tools/bugreport/BugReportQueue.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/preferences/AbstractProperty.java

@@ -14 +14 @@
 
     private final class PreferenceChangedListenerAdapter implements PreferenceChangedListener {
-        private ValueChangeListener<? super T> listener;
+        private final ValueChangeListener<? super T> listener;
 
         PreferenceChangedListenerAdapter(ValueChangeListener<? super T> listener) {

trunk/src/org/openstreetmap/josm/data/preferences/AbstractToStringProperty.java

@@ -25 +25 @@
      */
     public static class ChildProperty<T> extends AbstractToStringProperty<T> {
-        private AbstractToStringProperty<T> parent;
+        private final AbstractToStringProperty<T> parent;
 
         ChildProperty(AbstractToStringProperty<T> parent, String key) {

trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java

@@ -22 +22 @@
     private transient TagCollection tags;
     private List<String> displayedKeys;
-    private Set<String> keysWithConflicts = new HashSet<>();
+    private final Set<String> keysWithConflicts = new HashSet<>();
     private transient Map<String, MultiValueResolutionDecision> decisions;
     private int numConflicts;

trunk/src/org/openstreetmap/josm/gui/layer/imagery/TileCoordinateConverter.java

@@ -23 +23 @@
     private MapView mapView;
     private TileSourceDisplaySettings settings;
-    private TileSource tileSource;
+    private final TileSource tileSource;
 
     /**

trunk/src/org/openstreetmap/josm/tools/ListenerList.java

@@ -35 +35 @@
     private static final class WeakListener<T> {
 
-        private WeakReference<T> listener;
+        private final WeakReference<T> listener;
 
         WeakListener(T listener) {
@@ -62 +62 @@
         @Override
         public String toString() {
-            return "WeakListener [listener=" + listener + "]";
+            return "WeakListener [listener=" + listener + ']';
         }
     }
@@ -165 +165 @@
      */
     public static class TracingListenerList<T> extends ListenerList<T> {
-        private HashMap<T, StackTraceElement[]> listenersAdded = new HashMap<>();
-        private HashMap<T, StackTraceElement[]> listenersRemoved = new HashMap<>();
+        private final HashMap<T, StackTraceElement[]> listenersAdded = new HashMap<>();
+        private final HashMap<T, StackTraceElement[]> listenersRemoved = new HashMap<>();
 
         protected TracingListenerList() {

trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportQueue.java

@@ -20 +20 @@
     private static final BugReportQueue INSTANCE = new BugReportQueue();
 
-    private LinkedList<ReportedException> reportsToDisplay = new LinkedList<>();
+    private final LinkedList<ReportedException> reportsToDisplay = new LinkedList<>();
     private boolean suppressAllMessages;
-    private ArrayList<ReportedException> suppressFor = new ArrayList<>();
+    private final ArrayList<ReportedException> suppressFor = new ArrayList<>();
     private Thread displayThread;
     private final BiFunction<ReportedException, Integer, SuppressionMode> bugReportHandler = getBestHandler();