Changeset 10936 in josm

Timestamp:

2016-09-03T03:27:18+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (1 diff)
• actions/ImageryAdjustAction.java (modified) (2 diffs)
• actions/ShowStatusReportAction.java (modified) (1 diff)
• actions/mapmode/DrawAction.java (modified) (1 diff)
• gui/ProgramArguments.java (modified) (3 diffs)
• gui/datatransfer/AbstractStackTransferHandler.java (modified) (3 diffs)
• gui/datatransfer/OpenTransferHandler.java (modified) (2 diffs)
• gui/datatransfer/OsmTransferHandler.java (modified) (2 diffs)
• io/protocols/data/Handler.java (modified) (1 diff)
• tools/ListenerList.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -593 +593 @@
 
         private final String name;
-        private Runnable task;
+        private final Runnable task;
 
         protected InitializationTask(String name, Runnable task) {

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -304 +304 @@
         }
 
-        private void restoreMapModeState() {
-            if (Main.map == null)
-                return;
-            if (oldMapMode != null) {
-                Main.map.selectMapMode(oldMapMode);
-                oldMapMode = null;
-            } else {
-                Main.map.selectSelectTool(false);
-            }
-        }
-
         class WindowEventHandler extends WindowAdapter {
             @Override
@@ -321 +310 @@
                 restoreMapModeState();
             }
+
+            private void restoreMapModeState() {
+                if (Main.map == null)
+                    return;
+                if (oldMapMode != null) {
+                    Main.map.selectMapMode(oldMapMode);
+                    oldMapMode = null;
+                } else {
+                    Main.map.selectSelectTool(false);
+                }
+            }
         }
     }

trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java

@@ -93 +93 @@
             .append(runtimeVersion != null ? runtimeVersion : System.getProperty("java.version")).append(", ")
             .append(System.getProperty("java.vendor")).append(", ")
-            .append(System.getProperty("java.vm.name")).append('\n');
-
-        text.append("Screen: ");
+            .append(System.getProperty("java.vm.name"))
+            .append("\nScreen: ");
         if (!GraphicsEnvironment.isHeadless()) {
             text.append(Arrays.stream(GraphicsEnvironment.getLocalGraphicsEnvironment().getScreenDevices()).map(gd -> {

trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -640 +640 @@
     }
 
-    private String getTitle(boolean newNode, Node n, Collection<OsmPrimitive> newSelection, List<Way> reuseWays,
+    private static String getTitle(boolean newNode, Node n, Collection<OsmPrimitive> newSelection, List<Way> reuseWays,
             boolean extendedWay) {
         String title;

trunk/src/org/openstreetmap/josm/gui/ProgramArguments.java

@@ -29 +29 @@
      * JOSM command line options.
      * @see <a href="https://josm.openstreetmap.de/wiki/Help/CommandLineOptions">Help/CommandLineOptions</a>
-     * @since xxx
      */
     public enum Option {
@@ -102 +101 @@
      * Construct the program arguments object
      * @param args The args passed to main.
-     */
-    public ProgramArguments(String[] args) {
+     * @since 10936
+     */
+    public ProgramArguments(String ... args) {
         Stream.of(Option.values()).forEach(o -> argMap.put(o, new ArrayList<>()));
-
         buildCommandLineArgumentMap(args);
     }
@@ -216 +215 @@
     }
 
-    private static String getValue(String[] kv) {
+    private static String getValue(String ... kv) {
         if (kv.length < 2) {
             return "";

trunk/src/org/openstreetmap/josm/gui/datatransfer/AbstractStackTransferHandler.java

@@ -4 +4 @@
 import java.awt.datatransfer.UnsupportedFlavorException;
 import java.io.IOException;
+import java.util.Arrays;
 import java.util.Collection;
 
@@ -49 +50 @@
             if (df.supports(support)) {
                 try {
+                    if (Main.isDebugEnabled()) {
+                        Main.debug("{0} pasting {1} at {2}", df.getClass().getSimpleName(), Arrays.toString(support.getDataFlavors()), center);
+                    }
                     if (df.importData(support, layer, center)) {
                         return true;
@@ -55 +59 @@
                     Main.warn(e);
                 } catch (RuntimeException e) {
-                    BugReport.intercept(e).put("paster", df).put("flavors", () -> support.getDataFlavors()).warn();
+                    BugReport.intercept(e).put("paster", df).put("flavors", support::getDataFlavors).warn();
                 }
             }

trunk/src/org/openstreetmap/josm/gui/datatransfer/OpenTransferHandler.java

@@ -4 +4 @@
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;
 
 import org.openstreetmap.josm.gui.datatransfer.importers.AbstractOsmDataPaster;
@@ -22 +23 @@
     @Override
     protected Collection<AbstractOsmDataPaster> getSupportedPasters() {
-        return SUPPORTED;
+        return Collections.unmodifiableCollection(SUPPORTED);
     }
 }

trunk/src/org/openstreetmap/josm/gui/datatransfer/OsmTransferHandler.java

@@ -8 +8 @@
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;
 
 import org.openstreetmap.josm.Main;
@@ -35 +36 @@
     @Override
     protected Collection<AbstractOsmDataPaster> getSupportedPasters() {
-        return SUPPORTED;
+        return Collections.unmodifiableCollection(SUPPORTED);
     }
 

trunk/src/org/openstreetmap/josm/io/protocols/data/Handler.java

@@ -32 +32 @@
         String protocolHandlers = System.getProperty("java.protocol.handler.pkgs", "");
         if (!protocolHandlers.contains(pkg)) {
-            if (!protocolHandlers.isEmpty()) {
-                protocolHandlers += "|";
+            StringBuilder sb = new StringBuilder(protocolHandlers);
+            if (sb.length() > 0) {
+                sb.append('|');
             }
-            protocolHandlers += pkg;
-            Utils.updateSystemProperty("java.protocol.handler.pkgs", protocolHandlers);
+            sb.append(pkg);
+            Utils.updateSystemProperty("java.protocol.handler.pkgs", sb.toString());
         }
     }

trunk/src/org/openstreetmap/josm/tools/ListenerList.java

@@ -106 +106 @@
     protected void failAdd(T listener) {
         throw new IllegalArgumentException(
-                MessageFormat.format("Listener {0} (instance of {1}) was already registered.", listener.toString(),
+                MessageFormat.format("Listener {0} (instance of {1}) was already registered.", listener,
                         listener.getClass().getName()));
     }
@@ -128 +128 @@
         throw new IllegalArgumentException(
                 MessageFormat.format("Listener {0} (instance of {1}) was not registered before or already removed.",
-                        listener.toString(), listener.getClass().getName()));
+                        listener, listener.getClass().getName()));
     }