Changeset 10780 in josm

Timestamp:

2016-08-11T15:26:17+02:00 (8 years ago)

Author:

simon04

Message:

MatchFactory: check for keyword collisions

File:

• trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java

@@ -97 +97 @@
     public static void addMatchFactory(MatchFactory factory) {
         for (String keyword : factory.getKeywords()) {
-            // TODO: check for keyword collisions
+            final MatchFactory existing;
             if (factory instanceof SimpleMatchFactory) {
-                simpleMatchFactoryMap.put(keyword, (SimpleMatchFactory) factory);
+                existing = simpleMatchFactoryMap.put(keyword, (SimpleMatchFactory) factory);
             } else if (factory instanceof UnaryMatchFactory) {
-                unaryMatchFactoryMap.put(keyword, (UnaryMatchFactory) factory);
+                existing = unaryMatchFactoryMap.put(keyword, (UnaryMatchFactory) factory);
             } else if (factory instanceof BinaryMatchFactory) {
-                binaryMatchFactoryMap.put(keyword, (BinaryMatchFactory) factory);
+                existing = binaryMatchFactoryMap.put(keyword, (BinaryMatchFactory) factory);
             } else
                 throw new AssertionError("Unknown match factory");
+            if (existing != null) {
+                Main.warn("SearchCompiler: for key ''{0}'', overriding match factory ''{1}'' with ''{2}''", keyword, existing, factory);
+            }
         }
     }