Changeset 10597 in josm


Ignore:
Timestamp:
2016-07-23T01:02:41+02:00 (4 years ago)
Author:
Don-vip
Message:

see #12905 - sonar - pmd:BooleanGetMethodName - A getX() method which returns a boolean should be named isX()

Location:
trunk/src/org/openstreetmap/josm/tools/bugreport
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/tools/bugreport/BugReport.java

    r10586 r10597  
    5555
    5656    /**
    57      * Get if this report should include a system status report
     57     * Determines if this report should include a system status report
    5858     * @return <code>true</code> to include it.
    59      * @since 10585
    60      */
    61     public boolean getIncludeStatusReport() {
     59     * @since 10597
     60     */
     61    public boolean isIncludeStatusReport() {
    6262        return includeStatusReport;
    6363    }
     
    7474
    7575    /**
    76      * Get if this report should include the data that was traced.
     76     * Determines if this report should include the data that was traced.
    7777     * @return <code>true</code> to include it.
    78      * @since 10585
    79      */
    80     public boolean getIncludeData() {
     78     * @since 10597
     79     */
     80    public boolean isIncludeData() {
    8181        return includeData;
    8282    }
     
    9393
    9494    /**
    95      * Get if this report should include the stack traces for all other threads.
     95     * Determines if this report should include the stack traces for all other threads.
    9696     * @return <code>true</code> to include it.
    97      * @since 10585
    98      */
    99     public boolean getIncludeAllStackTraces() {
     97     * @since 10597
     98     */
     99    public boolean isIncludeAllStackTraces() {
    100100        return includeAllStackTraces;
    101101    }
     
    119119        StringWriter stringWriter = new StringWriter();
    120120        PrintWriter out = new PrintWriter(stringWriter);
    121         if (getIncludeStatusReport()) {
     121        if (isIncludeStatusReport()) {
    122122            out.println(ShowStatusReportAction.getReportHeader());
    123123        }
    124         if (getIncludeData()) {
     124        if (isIncludeData()) {
    125125            exception.printReportDataTo(out);
    126126        }
    127127        exception.printReportStackTo(out);
    128         if (getIncludeAllStackTraces()) {
     128        if (isIncludeAllStackTraces()) {
    129129            exception.printReportThreadsTo(out);
    130130        }
  • trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportSettingsPanel.java

    r10585 r10597  
    2222
    2323        JCheckBox statusReport = new JCheckBox(tr("Include the system status report."));
    24         statusReport.setSelected(report.getIncludeStatusReport());
     24        statusReport.setSelected(report.isIncludeStatusReport());
    2525        statusReport.addChangeListener(e -> report.setIncludeStatusReport(statusReport.isSelected()));
    2626        add(statusReport);
    2727
    2828        JCheckBox data = new JCheckBox(tr("Include information about the data that was worked on."));
    29         data.setSelected(report.getIncludeData());
     29        data.setSelected(report.isIncludeData());
    3030        data.addChangeListener(e -> report.setIncludeData(data.isSelected()));
    3131        add(data);
    3232
    3333        JCheckBox allStackTraces = new JCheckBox(tr("Include all stack traces."));
    34         allStackTraces.setSelected(report.getIncludeAllStackTraces());
     34        allStackTraces.setSelected(report.isIncludeAllStackTraces());
    3535        allStackTraces.addChangeListener(e -> report.setIncludeAllStackTraces(allStackTraces.isSelected()));
    3636        add(allStackTraces);
Note: See TracChangeset for help on using the changeset viewer.