Changeset 10316 in josm

Timestamp:

2016-06-02T02:46:59+02:00 (7 years ago)

Author:

Don-vip

Message:

fix coverity 1313942 + 1353522 - Integer handling issues

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/dialogs/DialogsPanel.java (modified) (1 diff)
• tools/GeoPropertyIndex.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/DialogsPanel.java

@@ -236 +236 @@
                         dlg.setPreferredSize(new Dimension(Integer.MAX_VALUE, hn));
                     } else {
-                        int d;
-                        try {
-                            d = (h0-he) * dm / dp;
-                        } catch (ArithmeticException e) { /* D_p may be zero - nothing wrong with that. */
-                            d = 0;
-                        }
+                        int d = dp == 0 ? 0 : ((h0-he) * dm / dp);
                         dlg.setPreferredSize(new Dimension(Integer.MAX_VALUE, h0 - d));
                     }

trunk/src/org/openstreetmap/josm/tools/GeoPropertyIndex.java

@@ -73 +73 @@
 
     public static int index(LatLon ll, int level) {
-        long noParts = 1 << level;
+        long noParts = 1L << level;
         long x = ((long) ((ll.lon() + 180.0) * noParts / 360.0)) & 1;
         long y = ((long) ((ll.lat() + 90.0) * noParts / 180.0)) & 1;