Changeset 10294 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2016-05-29T00:14:28+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S1848 - refactor URL checks

File:

• trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java

@@ -12 +12 @@
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.text.MessageFormat;
@@ -206 +205 @@
             s = attr.getValue("Plugin-Link");
         }
-        if (s != null) {
-            try {
-                new URL(s);
-            } catch (MalformedURLException e) {
-                Main.info(tr("Invalid URL ''{0}'' in plugin {1}", s, name));
-                s = null;
-            }
+        if (s != null && !Utils.isValidUrl(s)) {
+            Main.info(tr("Invalid URL ''{0}'' in plugin {1}", s, name));
+            s = null;
         }
         link = s;