Changeset 10292 in josm for trunk

Timestamp:

2016-05-28T23:16:07+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S2275 - Format specifiers should be used instead of string concatenation

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/ImageryAdjustAction.java (modified) (1 diff)
• data/SystemOfMeasurement.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -261 +261 @@
             // US locale to force decimal separator to be '.'
             try (Formatter us = new Formatter(Locale.US)) {
-                tOffset.setText(us.format(
-                    "%1." + precision + "f; %1." + precision + 'f',
+                tOffset.setText(us.format(new StringBuilder()
+                    .append("%1.").append(precision).append("f; %1.").append(precision).append('f').toString(),
                     layer.getDx(), layer.getDy()).toString());
             }

trunk/src/org/openstreetmap/josm/data/SystemOfMeasurement.java

@@ -268 +268 @@
             return format.format(v) + ' ' + unit;
         }
-        return String.format(Locale.US, "%." + (v < 9.999999 ? 2 : 1) + "f %s", v, unit);
+        return String.format(Locale.US, v < 9.999999 ? "%.2f %s" : "%.1f %s", v, unit);
     }
 }