Changeset 10268 in josm


Ignore:
Timestamp:
2016-05-23T13:57:26+02:00 (7 years ago)
Author:
Don-vip
Message:

sonar - squid:AssignmentInSubExpressionCheck - Assignments should not be made from within sub-expressions

Location:
trunk/src/org/openstreetmap/josm/gui
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSStyleSource.java

    r10000 r10268  
    639639            MapCSSRule r = candidates.next();
    640640            env.clearSelectorMatchingInformation();
    641             env.layer = null;
    642             String sub = env.layer = r.selector.getSubpart().getId(env);
     641            env.layer = r.selector.getSubpart().getId(env);
     642            String sub = env.layer;
    643643            if (r.selector.matches(env)) { // as side effect env.parent will be set (if s is a child selector)
    644644                Selector s = r.selector;
  • trunk/src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java

    r10217 r10268  
    151151        SelectAllOnFocusGainedDecorator.decorate(tfOsmLogoutURL);
    152152
    153         cbUseDefaults.addItemListener(ilUseDefault = new UseDefaultItemListener());
     153        ilUseDefault = new UseDefaultItemListener();
     154        cbUseDefaults.addItemListener(ilUseDefault);
    154155    }
    155156
Note: See TracChangeset for help on using the changeset viewer.