Changeset 10254 in josm


Ignore:
Timestamp:
2016-05-20T22:21:01+02:00 (3 years ago)
Author:
Don-vip
Message:

sonar - squid:S1948 - Fields in a "Serializable" class should either be transient or serializable

Location:
trunk/src/org/openstreetmap/josm
Files:
12 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java

    r10174 r10254  
    226226    static class SegmentToKeepSelectionDialog extends ExtendedDialog {
    227227        static final AtomicInteger DISPLAY_COUNT = new AtomicInteger();
    228         final Way selectedWay;
    229         final List<Way> newWays;
     228        final transient Way selectedWay;
     229        final transient List<Way> newWays;
    230230        final JList<Way> list;
    231         final List<OsmPrimitive> selection;
    232         final Way wayToKeep;
     231        final transient List<OsmPrimitive> selection;
     232        final transient Way wayToKeep;
    233233
    234234        SegmentToKeepSelectionDialog(Way selectedWay, List<Way> newWays, Way wayToKeep, List<OsmPrimitive> selection) {
  • trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java

    r10181 r10254  
    203203    static final class PropertiesMembershipDialog extends ExtendedDialog {
    204204
    205         final ExistingBothNewChoice tags;
    206         final ExistingBothNewChoice memberships;
     205        final transient ExistingBothNewChoice tags;
     206        final transient ExistingBothNewChoice memberships;
    207207
    208208        private PropertiesMembershipDialog(boolean preselectNew, boolean queryTags, boolean queryMemberships) {
  • trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

    r10216 r10254  
    17941794
    17951795    private class ComputeStyleListWorker extends RecursiveTask<List<StyleRecord>> implements Visitor {
    1796         private final List<? extends OsmPrimitive> input;
    1797         private final List<StyleRecord> output;
    1798 
    1799         private final ElemStyles styles = MapPaintStyles.getStyles();
     1796        private final transient List<? extends OsmPrimitive> input;
     1797        private final transient List<StyleRecord> output;
     1798
     1799        private final transient ElemStyles styles = MapPaintStyles.getStyles();
    18001800        private final int directExecutionTaskSize;
    18011801
  • trunk/src/org/openstreetmap/josm/gui/SplashScreen.java

    r10173 r10254  
    5050public class SplashScreen extends JFrame implements ChangeListener {
    5151
    52     private final SplashProgressMonitor progressMonitor;
     52    private final transient SplashProgressMonitor progressMonitor;
    5353    private final SplashScreenProgressRenderer progressRenderer;
    5454
  • trunk/src/org/openstreetmap/josm/gui/dialogs/DialogsPanel.java

    r10001 r10254  
    1919
    2020public class DialogsPanel extends JPanel implements Destroyable {
    21     protected List<ToggleDialog> allDialogs = new ArrayList<>();
    22     protected MultiSplitPane mSpltPane = new MultiSplitPane();
    23     protected static final int DIVIDER_SIZE = 5;
     21    private final List<ToggleDialog> allDialogs = new ArrayList<>();
     22    private final MultiSplitPane mSpltPane = new MultiSplitPane();
     23    private static final int DIVIDER_SIZE = 5;
    2424
    2525    /**
     
    4040            throw new IllegalStateException();
    4141        initialized = true;
    42         allDialogs = new ArrayList<>();
     42        allDialogs.clear();
    4343
    4444        for (ToggleDialog dialog: pAllDialogs) {
  • trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

    r10228 r10254  
    12301230    class TaginfoAction extends JosmAction {
    12311231
    1232         final StringProperty TAGINFO_URL_PROP = new StringProperty("taginfo.url", "https://taginfo.openstreetmap.org/");
     1232        final transient StringProperty TAGINFO_URL_PROP = new StringProperty("taginfo.url", "https://taginfo.openstreetmap.org/");
    12331233
    12341234        TaginfoAction() {
  • trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

    r10250 r10254  
    10001000
    10011001        class IgnoreTagAction extends AbstractAction {
    1002             final Tag tag;
     1002            final transient Tag tag;
    10031003
    10041004            IgnoreTagAction(String name, Tag tag) {
  • trunk/src/org/openstreetmap/josm/gui/history/CoordinateInfoViewer.java

    r10210 r10254  
    245245        private final JosmTextArea lblLat = newTextArea();
    246246        private final JosmTextArea lblLon = newTextArea();
    247         private final Updater updater;
     247        private final transient Updater updater;
    248248        private final Color modifiedColor;
    249249
     
    331331    private static class MapViewer extends JMapViewer implements ChangeListener {
    332332
    333         private final Updater updater;
     333        private final transient Updater updater;
    334334
    335335        MapViewer(HistoryBrowserModel model) {
     
    365365
    366366        private final JosmTextArea lblDistance = newTextArea();
    367         private final Updater updater;
     367        private final transient Updater updater;
    368368
    369369        DistanceViewer(HistoryBrowserModel model) {
  • trunk/src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java

    r10183 r10254  
    5858 * This wizard walks the user to the necessary steps to retrieve an OAuth Access Token which
    5959 * allows JOSM to access the OSM API on the users behalf.
    60  *
     60 * @since 2746
    6161 */
    6262public class OAuthAuthorizationWizard extends JDialog {
     
    6969    private ManualAuthorizationUI pnlManualAuthorisationUI;
    7070    private JScrollPane spAuthorisationProcedureUI;
    71     private final Executor executor;
     71    private final transient Executor executor;
    7272
    7373    /**
  • trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletingComboBox.java

    r10132 r10254  
    3939    private int maxTextLength = -1;
    4040    private boolean useFixedLocale;
     41
     42    private final transient InputContext privateInputContext = InputContext.getInstance();
    4143
    4244    /**
     
    335337    }
    336338
    337     private final InputContext privateInputContext = InputContext.getInstance();
    338 
    339339    @Override
    340340    public InputContext getInputContext() {
  • trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPreset.java

    r9991 r10254  
    9696     * The types as preparsed collection.
    9797     */
    98     public Set<TaggingPresetType> types;
     98    public transient Set<TaggingPresetType> types;
    9999    public final transient List<TaggingPresetItem> data = new LinkedList<>();
    100100    public transient Roles roles;
  • trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetReader.java

    r9799 r10254  
    8181
    8282    static class HashSetWithLast<E> extends LinkedHashSet<E> {
    83         protected E last;
     83        protected transient E last;
    8484
    8585        @Override
Note: See TracChangeset for help on using the changeset viewer.