Changeset 10222 in josm for trunk/test/unit/org/openstreetmap/josm/data/osm

Timestamp:

2016-05-15T21:14:06+02:00 (10 years ago)

Author:

Don-vip

Message:

findbugs - fix/suppress most of warnings reported in unit tests + enable low confidence warnings for core

Location:

trunk/test/unit/org/openstreetmap/josm/data/osm

Files:

• ChangesetCacheTest.groovy (modified) (6 diffs)
• FilterTest.java (modified) (1 diff)
• MultipolygonBuilderTest.java (modified) (2 diffs)
• OsmPrimitiveKeyHandlingTest.java (modified) (2 diffs)
• RelationTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/osm/ChangesetCacheTest.groovy

@@ -9 +9 @@
 
     @Test
-    public void test_Constructor() {
+    public void testConstructor() {
         ChangesetCache cache = ChangesetCache.getInstance()
         assert cache != null
@@ -15 +15 @@
 
     @Test
-    public void test_addAndRemoveListeners() {
+    public void testAddAndRemoveListeners() {
         ChangesetCache cache = ChangesetCache.getInstance()
         cache.clear()
@@ -38 +38 @@
 
     @Test
-    public void update_get_remove_cycle() {
+    public void updateGetRemoveCycle() {
         ChangesetCache cache = ChangesetCache.getInstance()
         cache.clear()
@@ -97 +97 @@
 
     @Test
-    public void fireingEvents_AddAChangeset() {
+    public void fireingEventsAddAChangeset() {
         ChangesetCache cache = ChangesetCache.getInstance()
         cache.clear()
@@ -118 +118 @@
 
     @Test
-    public void fireingEvents_UpdateChangeset() {
+    public void fireingEventsUpdateChangeset() {
         ChangesetCache cache = ChangesetCache.getInstance()
         cache.clear()
@@ -141 +141 @@
 
     @Test
-    public void fireingEvents_RemoveChangeset() {
+    public void fireingEventsRemoveChangeset() {
         ChangesetCache cache = ChangesetCache.getInstance()
         cache.clear()

trunk/test/unit/org/openstreetmap/josm/data/osm/FilterTest.java

@@ -161 +161 @@
                 break;
             }
+            default: throw new AssertionError();
             }
 

trunk/test/unit/org/openstreetmap/josm/data/osm/MultipolygonBuilderTest.java

@@ -14 +14 @@
 import org.openstreetmap.josm.io.OsmReader;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 /**
  * Unit tests of the {@code MultipolygonBuilder} class.
@@ -23 +25 @@
      */
     @Rule
+    @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
     public Timeout globalTimeout = Timeout.seconds(15);
 

trunk/test/unit/org/openstreetmap/josm/data/osm/OsmPrimitiveKeyHandlingTest.java

@@ -10 +10 @@
 import org.openstreetmap.josm.JOSMFixture;
 import org.openstreetmap.josm.data.coor.LatLon;
+
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 /**
@@ -72 +74 @@
      */
     @Test
+    @SuppressFBWarnings(value = "DM_STRING_CTOR", justification = "test that equals is used and not ==")
     public void remove() {
         Node n = new Node();

trunk/test/unit/org/openstreetmap/josm/data/osm/RelationTest.java

@@ -34 +34 @@
 
     @Test
-    public void testBBox() {
+    public void testBbox() {
         DataSet ds = new DataSet();