Changeset 10222 in josm for trunk/test/functional/org

Timestamp:

2016-05-15T21:14:06+02:00 (9 years ago)

Author:

Don-vip

Message:

findbugs - fix/suppress most of warnings reported in unit tests + enable low confidence warnings for core

Location:

trunk/test/functional/org/openstreetmap/josm/io

Files:

• MultiFetchServerObjectReaderTest.java (modified) (2 diffs)
• OsmServerBackreferenceReaderTest.java (modified) (3 diffs)
• UploadStrategySelectionPanelTest.java (modified) (2 diffs)

trunk/test/functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java

@@ -18 +18 @@
 import java.text.MessageFormat;
 import java.util.ArrayList;
+import java.util.Locale;
 import java.util.logging.Logger;
 
@@ -151 +152 @@
 
         String p = System.getProperties().getProperty("useCachedDataset");
-        if (p != null && Boolean.parseBoolean(p.trim().toLowerCase())) {
+        if (p != null && Boolean.parseBoolean(p.trim().toLowerCase(Locale.ENGLISH))) {
             logger.info(MessageFormat.format("property ''{0}'' set, using cached dataset", "useCachedDataset"));
             return;

trunk/test/functional/org/openstreetmap/josm/io/OsmServerBackreferenceReaderTest.java

@@ -18 +18 @@
 import java.text.MessageFormat;
 import java.util.HashSet;
+import java.util.Locale;
 import java.util.Set;
 import java.util.logging.Logger;
@@ -169 +170 @@
 
         String p = System.getProperty("useCachedDataset");
-        if (p != null && Boolean.parseBoolean(p.trim().toLowerCase())) {
+        if (p != null && Boolean.parseBoolean(p.trim().toLowerCase(Locale.ENGLISH))) {
             logger.info(MessageFormat.format("property ''{0}'' set, using cached dataset", "useCachedDataset"));
             return;
@@ -516 +517 @@
         DataSet referers = reader.parseOsm(NullProgressMonitor.INSTANCE);
 
-        Set<Long> referringRelationsIds = new HashSet<>();
         r = lookupRelation(referers, 6);
         assertNotNull(r);
         assertFalse(r.isIncomplete());
-        referringRelationsIds.add(r.getId());
         r = lookupRelation(referers, 7);
         assertNotNull(r);
         assertFalse(r.isIncomplete());
-        referringRelationsIds.add(r.getId());
         r = lookupRelation(referers, 8);
         assertNotNull(r);
         assertFalse(r.isIncomplete());
-        referringRelationsIds.add(r.getId());
         r = lookupRelation(referers, 9);
         assertNotNull(r);
         assertFalse(r.isIncomplete());
-        referringRelationsIds.add(r.getId());
 
         // all relations are fully loaded

trunk/test/functional/org/openstreetmap/josm/io/UploadStrategySelectionPanelTest.java

@@ -20 +20 @@
 public class UploadStrategySelectionPanelTest extends JFrame {
 
-    private UploadStrategySelectionPanel uploadStrategySelectionPanel;
+    protected UploadStrategySelectionPanel uploadStrategySelectionPanel;
 
     protected void build()  {
@@ -37 +37 @@
         tf.addActionListener(
                 new ActionListener() {
-                    public void actionPerformed(ActionEvent arg0) {
+                    @Override
+                    public void actionPerformed(ActionEvent ae) {
                         int n = 0;
                         try {