Changeset 10222 in josm for trunk/test/functional


Ignore:
Timestamp:
2016-05-15T21:14:06+02:00 (3 years ago)
Author:
Don-vip
Message:

findbugs - fix/suppress most of warnings reported in unit tests + enable low confidence warnings for core

Location:
trunk/test/functional/org/openstreetmap/josm/io
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/test/functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java

    r9655 r10222  
    1818import java.text.MessageFormat;
    1919import java.util.ArrayList;
     20import java.util.Locale;
    2021import java.util.logging.Logger;
    2122
     
    151152
    152153        String p = System.getProperties().getProperty("useCachedDataset");
    153         if (p != null && Boolean.parseBoolean(p.trim().toLowerCase())) {
     154        if (p != null && Boolean.parseBoolean(p.trim().toLowerCase(Locale.ENGLISH))) {
    154155            logger.info(MessageFormat.format("property ''{0}'' set, using cached dataset", "useCachedDataset"));
    155156            return;
  • trunk/test/functional/org/openstreetmap/josm/io/OsmServerBackreferenceReaderTest.java

    r9374 r10222  
    1818import java.text.MessageFormat;
    1919import java.util.HashSet;
     20import java.util.Locale;
    2021import java.util.Set;
    2122import java.util.logging.Logger;
     
    169170
    170171        String p = System.getProperty("useCachedDataset");
    171         if (p != null && Boolean.parseBoolean(p.trim().toLowerCase())) {
     172        if (p != null && Boolean.parseBoolean(p.trim().toLowerCase(Locale.ENGLISH))) {
    172173            logger.info(MessageFormat.format("property ''{0}'' set, using cached dataset", "useCachedDataset"));
    173174            return;
     
    516517        DataSet referers = reader.parseOsm(NullProgressMonitor.INSTANCE);
    517518
    518         Set<Long> referringRelationsIds = new HashSet<>();
    519519        r = lookupRelation(referers, 6);
    520520        assertNotNull(r);
    521521        assertFalse(r.isIncomplete());
    522         referringRelationsIds.add(r.getId());
    523522        r = lookupRelation(referers, 7);
    524523        assertNotNull(r);
    525524        assertFalse(r.isIncomplete());
    526         referringRelationsIds.add(r.getId());
    527525        r = lookupRelation(referers, 8);
    528526        assertNotNull(r);
    529527        assertFalse(r.isIncomplete());
    530         referringRelationsIds.add(r.getId());
    531528        r = lookupRelation(referers, 9);
    532529        assertNotNull(r);
    533530        assertFalse(r.isIncomplete());
    534         referringRelationsIds.add(r.getId());
    535531
    536532        // all relations are fully loaded
  • trunk/test/functional/org/openstreetmap/josm/io/UploadStrategySelectionPanelTest.java

    r8514 r10222  
    2020public class UploadStrategySelectionPanelTest extends JFrame {
    2121
    22     private UploadStrategySelectionPanel uploadStrategySelectionPanel;
     22    protected UploadStrategySelectionPanel uploadStrategySelectionPanel;
    2323
    2424    protected void build()  {
     
    3737        tf.addActionListener(
    3838                new ActionListener() {
    39                     public void actionPerformed(ActionEvent arg0) {
     39                    @Override
     40                    public void actionPerformed(ActionEvent ae) {
    4041                        int n = 0;
    4142                        try {
Note: See TracChangeset for help on using the changeset viewer.