Changeset 10214 in josm for trunk/src/org

Timestamp:

2016-05-15T12:43:59+02:00 (9 years ago)

Author:

Don-vip

Message:

findbugs - SE_BAD_FIELD_STORE + LI_LAZY_INIT_UPDATE_STATIC

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/mapmode/ImproveWayAccuracyAction.java (modified) (1 diff)
• data/validation/OsmValidator.java (modified) (1 diff)
• data/validation/util/Entities.java (modified) (2 diffs)
• tools/bugreport/BugReportExceptionHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyAction.java

@@ -91 +91 @@
     protected String oldModeHelpText;
 
-    private final AbstractMapViewPaintable temporaryLayer = new AbstractMapViewPaintable() {
+    private final transient AbstractMapViewPaintable temporaryLayer = new AbstractMapViewPaintable() {
         @Override
         public void paint(Graphics2D g, MapView mv, Bounds bbox) {

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -206 +206 @@
     }
 
-    public static void initializeErrorLayer() {
+    public static synchronized void initializeErrorLayer() {
         if (!Main.pref.getBoolean(ValidatorPreference.PREF_LAYER, true))
             return;

trunk/src/org/openstreetmap/josm/data/validation/util/Entities.java

@@ -391 +391 @@
                         }
                     } else { // escaped value content is an entity name
-                        if (mapNameToValue == null) {
-                            mapNameToValue = new HashMap<>();
-                            for (String[] pair : ARRAY) {
-                                mapNameToValue.put(pair[0], pair[1]);
-                            }
-                        }
-                        String value = mapNameToValue.get(entityContent);
+                        String value = getMapNameToValue().get(entityContent);
                         entityValue = value == null ? -1 : Integer.parseInt(value);
                     }
@@ -414 +408 @@
         return res.toString();
     }
+
+    private static synchronized Map<String, String> getMapNameToValue() {
+        if (mapNameToValue == null) {
+            mapNameToValue = new HashMap<>();
+            for (String[] pair : ARRAY) {
+                mapNameToValue.put(pair[0], pair[1]);
+            }
+        }
+        return mapNameToValue;
+    }
 }

trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportExceptionHandler.java

@@ -166 +166 @@
      * @param e the exception
      */
-    public static void handleException(final Throwable e) {
+    public static synchronized void handleException(final Throwable e) {
         if (handlingInProgress || suppressExceptionDialogs)
             return;                  // we do not handle secondary exceptions, this gets too messy