Changeset 10173 in josm for trunk/src/org/openstreetmap/josm/gui/io

Timestamp:

2016-05-10T14:54:38+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S1186 - Methods should not be empty

Location:

trunk/src/org/openstreetmap/josm/gui/io

Files:

• BasicUploadSettingsPanel.java (modified) (3 diffs)
• CredentialDialog.java (modified) (3 diffs)
• DownloadFileTask.java (modified) (1 diff)
• RecentlyOpenedFilesMenu.java (modified) (2 diffs)
• UploadStrategySelectionPanel.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/io/BasicUploadSettingsPanel.java

@@ -10 +10 @@
 import java.awt.event.FocusAdapter;
 import java.awt.event.FocusEvent;
+import java.awt.event.KeyAdapter;
 import java.awt.event.KeyEvent;
-import java.awt.event.KeyListener;
 import java.util.Arrays;
 import java.util.Collections;
@@ -135 +135 @@
         hcb.getEditor().addActionListener(handler);
         hcb.getEditorComponent().addKeyListener(
-                new KeyListener() {
+                new KeyAdapter() {
                     @Override
                     public void keyTyped(KeyEvent e) {
@@ -141 +141 @@
                             handler.actionPerformed(new ActionEvent(hcb, 0, "focusDown"));
                         }
-                    }
-
-                    @Override
-                    public void keyReleased(KeyEvent e) {
-                        // Do nothing
-                    }
-
-                    @Override
-                    public void keyPressed(KeyEvent e) {
-                        // Do nothing
                     }
                 }

trunk/src/org/openstreetmap/josm/gui/io/CredentialDialog.java

@@ -14 +14 @@
 import java.awt.event.FocusAdapter;
 import java.awt.event.FocusEvent;
+import java.awt.event.KeyAdapter;
 import java.awt.event.KeyEvent;
-import java.awt.event.KeyListener;
 import java.awt.event.WindowAdapter;
 import java.awt.event.WindowEvent;
@@ -344 +344 @@
      *   If both text fields contain characters, submits the form by calling owner's {@link OKAction}.
      */
-    private static class TFKeyListener implements KeyListener {
+    private static class TFKeyListener extends KeyAdapter {
         protected CredentialDialog owner; // owner Dependency Injection to call OKAction
         protected JTextField currentTF;
@@ -371 +371 @@
             }
         }
-
-        @Override
-        public void keyReleased(KeyEvent e) {
-        }
-
-        @Override
-        public void keyTyped(KeyEvent e) {
-        }
     }
 

trunk/src/org/openstreetmap/josm/gui/io/DownloadFileTask.java

@@ -85 +85 @@
 
     @Override
-    protected void finish() {}
+    protected void finish() {
+        // Do nothing
+    }
 
     /**

trunk/src/org/openstreetmap/josm/gui/io/RecentlyOpenedFilesMenu.java

@@ -27 +27 @@
     private ClearAction clearAction;
 
+    /**
+     * Constructs a new {@code RecentlyOpenedFilesMenu}.
+     */
     public RecentlyOpenedFilesMenu() {
         super(tr("Open Recent"));
@@ -42 +45 @@
             @Override
             public void menuDeselected(MenuEvent e) {
+                // Do nothing
             }
 
             @Override
             public void menuCanceled(MenuEvent e) {
+                // Do nothing
             }
         });

trunk/src/org/openstreetmap/josm/gui/io/UploadStrategySelectionPanel.java

@@ -12 +12 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
+import java.awt.event.FocusAdapter;
 import java.awt.event.FocusEvent;
-import java.awt.event.FocusListener;
 import java.awt.event.ItemEvent;
 import java.awt.event.ItemListener;
@@ -389 +389 @@
     }
 
-    static class TextFieldFocusHandler implements FocusListener {
+    static class TextFieldFocusHandler extends FocusAdapter {
         @Override
         public void focusGained(FocusEvent e) {
@@ -398 +398 @@
             }
         }
-
-        @Override
-        public void focusLost(FocusEvent e) {}
     }
 
@@ -467 +464 @@
     }
 
-    class StrategyChangeListener implements ItemListener, FocusListener, ActionListener {
+    class StrategyChangeListener extends FocusAdapter implements ItemListener, ActionListener {
 
         protected void notifyStrategy() {
@@ -489 +486 @@
 
         @Override
-        public void focusGained(FocusEvent arg0) {}
-
-        @Override
         public void focusLost(FocusEvent arg0) {
             notifyStrategy();