Changeset 10109 in josm

Timestamp:

2016-04-04T23:13:08+02:00 (8 years ago)

Author:

Don-vip

Message:

add unit test, javadoc, remove unused and untestable code

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/preferences/advanced/PreferencesTable.java (modified) (14 diffs)
• test/unit/org/openstreetmap/josm/gui/preferences/advanced/PreferencesTableTest.java (added)

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java

@@ -242 +242 @@
 
     /**
-     * replies the tag table model for the respective point in time
+     * Replies the tag table model for the respective point in time.
      *
      * @param pointInTimeType the type of the point in time (must not be null)
@@ -252 +252 @@
         if (pointInTimeType.equals(PointInTimeType.CURRENT_POINT_IN_TIME))
             return currentTagTableModel;
-        else if (pointInTimeType.equals(PointInTimeType.REFERENCE_POINT_IN_TIME))
+        else // REFERENCE_POINT_IN_TIME
             return referenceTagTableModel;
-
-        // should not happen
-        return null;
-    }
-
+    }
+
+    /**
+     * Replies the node list table model for the respective point in time.
+     *
+     * @param pointInTimeType the type of the point in time (must not be null)
+     * @return the node list table model
+     * @throws IllegalArgumentException if pointInTimeType is null
+     */
     public DiffTableModel getNodeListTableModel(PointInTimeType pointInTimeType) {
         CheckParameterUtil.ensureParameterNotNull(pointInTimeType, "pointInTimeType");
         if (pointInTimeType.equals(PointInTimeType.CURRENT_POINT_IN_TIME))
             return currentNodeListTableModel;
-        else if (pointInTimeType.equals(PointInTimeType.REFERENCE_POINT_IN_TIME))
+        else // REFERENCE_POINT_IN_TIME
             return referenceNodeListTableModel;
-
-        // should not happen
-        return null;
-    }
-
+    }
+
+    /**
+     * Replies the relation member table model for the respective point in time.
+     *
+     * @param pointInTimeType the type of the point in time (must not be null)
+     * @return the relation member table model
+     * @throws IllegalArgumentException if pointInTimeType is null
+     */
     public DiffTableModel getRelationMemberTableModel(PointInTimeType pointInTimeType) {
         CheckParameterUtil.ensureParameterNotNull(pointInTimeType, "pointInTimeType");
         if (pointInTimeType.equals(PointInTimeType.CURRENT_POINT_IN_TIME))
             return currentRelationMemberTableModel;
-        else if (pointInTimeType.equals(PointInTimeType.REFERENCE_POINT_IN_TIME))
+        else // REFERENCE_POINT_IN_TIME
             return referenceRelationMemberTableModel;
-
-        // should not happen
-        return null;
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/PreferencesTable.java

@@ -8 +8 @@
 import java.awt.Component;
 import java.awt.Font;
+import java.awt.GraphicsEnvironment;
 import java.awt.GridBagLayout;
 import java.awt.event.MouseAdapter;
@@ -95 +96 @@
     public boolean editPreference(final JComponent gui) {
         if (getSelectedRowCount() != 1) {
-            JOptionPane.showMessageDialog(
-                    gui,
-                    tr("Please select the row to edit."),
-                    tr("Warning"),
-                    JOptionPane.WARNING_MESSAGE
-                    );
+            if (!GraphicsEnvironment.isHeadless()) {
+                JOptionPane.showMessageDialog(
+                        gui,
+                        tr("Please select the row to edit."),
+                        tr("Warning"),
+                        JOptionPane.WARNING_MESSAGE
+                        );
+            }
             return false;
         }
@@ -122 +125 @@
     }
 
-    static boolean doEditList(final JComponent gui, final PrefEntry e, ListSetting lSetting) {
+    private static boolean doEditList(final JComponent gui, final PrefEntry e, ListSetting lSetting) {
         ListEditor lEditor = new ListEditor(gui, e, lSetting);
         lEditor.showDialog();
@@ -135 +138 @@
     }
 
-    static boolean doEditListList(final JComponent gui, final PrefEntry e, ListListSetting llSetting) {
+    private static boolean doEditListList(final JComponent gui, final PrefEntry e, ListListSetting llSetting) {
         ListListEditor llEditor = new ListListEditor(gui, e, llSetting);
         llEditor.showDialog();
@@ -148 +151 @@
     }
 
-    static boolean doEditMapList(final JComponent gui, final PrefEntry e, MapListSetting mlSetting) {
+    private static boolean doEditMapList(final JComponent gui, final PrefEntry e, MapListSetting mlSetting) {
         MapListEditor mlEditor = new MapListEditor(gui, e, mlSetting);
         mlEditor.showDialog();
@@ -192 +195 @@
         rbString.setSelected(true);
 
-        ExtendedDialog dlg = new ExtendedDialog(gui, tr("Add setting"), new String[] {tr("OK"), tr("Cancel")});
-        dlg.setButtonIcons(new String[] {"ok.png", "cancel.png"});
-        dlg.setContent(p);
-        dlg.showDialog();
-
         PrefEntry pe = null;
         boolean ok = false;
-        if (dlg.getValue() == 1) {
+        if (!GraphicsEnvironment.isHeadless() && askAddSetting(gui, p)) {
             if (rbString.isSelected()) {
                 StringSetting sSetting = new StringSetting(null);
@@ -221 +219 @@
     }
 
-    static boolean doAddSimple(final JComponent gui, PrefEntry pe, StringSetting sSetting) {
+    private static boolean askAddSetting(JComponent gui, JPanel p) {
+        return new ExtendedDialog(gui, tr("Add setting"), new String[] {tr("OK"), tr("Cancel")})
+                .setContent(p).setButtonIcons(new String[] {"ok.png", "cancel.png"}).showDialog().getValue() == 1;
+    }
+
+    private static boolean doAddSimple(final JComponent gui, PrefEntry pe, StringSetting sSetting) {
         StringEditor sEditor = new StringEditor(gui, pe, sSetting);
         sEditor.showDialog();
@@ -234 +237 @@
     }
 
-    static boolean doAddList(final JComponent gui, PrefEntry pe, ListSetting lSetting) {
+    private static boolean doAddList(final JComponent gui, PrefEntry pe, ListSetting lSetting) {
         ListEditor lEditor = new ListEditor(gui, pe, lSetting);
         lEditor.showDialog();
@@ -247 +250 @@
     }
 
-    static boolean doAddListList(final JComponent gui, PrefEntry pe, ListListSetting llSetting) {
+    private static boolean doAddListList(final JComponent gui, PrefEntry pe, ListListSetting llSetting) {
         ListListEditor llEditor = new ListListEditor(gui, pe, llSetting);
         llEditor.showDialog();
@@ -260 +263 @@
     }
 
-    static boolean doAddMapList(final JComponent gui, PrefEntry pe, MapListSetting mlSetting) {
+    private static boolean doAddMapList(final JComponent gui, PrefEntry pe, MapListSetting mlSetting) {
         MapListEditor mlEditor = new MapListEditor(gui, pe, mlSetting);
         mlEditor.showDialog();
@@ -279 +282 @@
     public void resetPreferences(final JComponent gui) {
         if (getSelectedRowCount() == 0) {
-            JOptionPane.showMessageDialog(
-                    gui,
-                    tr("Please select the row to delete."),
-                    tr("Warning"),
-                    JOptionPane.WARNING_MESSAGE
-                    );
+            if (!GraphicsEnvironment.isHeadless()) {
+                JOptionPane.showMessageDialog(
+                        gui,
+                        tr("Please select the row to delete."),
+                        tr("Warning"),
+                        JOptionPane.WARNING_MESSAGE
+                        );
+            }
             return;
         }
@@ -294 +299 @@
     }
 
-    private class AllSettingsTableModel extends DefaultTableModel {
+    final class AllSettingsTableModel extends DefaultTableModel {
 
         AllSettingsTableModel() {
@@ -329 +334 @@
     }
 
-    private static class SettingCellRenderer extends DefaultTableCellRenderer {
+    static final class SettingCellRenderer extends DefaultTableCellRenderer {
         private final Color backgroundColor = UIManager.getColor("Table.background");
         private final Color changedColor = Main.pref.getColor(
@@ -374 +379 @@
     }
 
-    private static class SettingCellEditor extends DefaultCellEditor {
+    static final class SettingCellEditor extends DefaultCellEditor {
         SettingCellEditor() {
             super(new JosmTextField());