Changeset 10002 in josm

Timestamp:

2016-03-17T01:56:30+01:00 (9 years ago)

Author:

Don-vip

Message:

sonar - User assertSame instead of assertTrue

File:

• trunk/test/performance/org/openstreetmap/josm/data/osm/KeyValuePerformanceTest.java (modified) (6 diffs)

trunk/test/performance/org/openstreetmap/josm/data/osm/KeyValuePerformanceTest.java

@@ -3 +3 @@
 
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
 
@@ -77 +79 @@
         timer = PerformanceTestUtils.startTimer("str1 == str2 succeeds");
         for (int i = 0; i < STRING_INTERN_TESTS; i++) {
-            assertTrue(str1Interned == str1InternedB);
+            assertSame(str1Interned, str1InternedB);
         }
         timer.done();
@@ -83 +85 @@
         timer = PerformanceTestUtils.startTimer("str1 == str2.intern() succeeds");
         for (int i = 0; i < STRING_INTERN_TESTS; i++) {
-            assertTrue(str1Interned == str1.intern());
+            assertSame(str1Interned, str1.intern());
         }
         timer.done();
@@ -89 +91 @@
         timer = PerformanceTestUtils.startTimer("str1 == str2.intern() succeeds for interned string");
         for (int i = 0; i < STRING_INTERN_TESTS; i++) {
-            assertTrue(str1Interned == str1InternedB.intern());
+            assertSame(str1Interned, str1InternedB.intern());
         }
         timer.done();
@@ -101 +103 @@
         timer = PerformanceTestUtils.startTimer("str1 == str2 fails");
         for (int i = 0; i < STRING_INTERN_TESTS; i++) {
-            assertFalse(str1Interned == str2Interned);
+            assertNotSame(str1Interned, str2Interned);
         }
         timer.done();
@@ -107 +109 @@
         timer = PerformanceTestUtils.startTimer("str1 == str2.intern() fails");
         for (int i = 0; i < STRING_INTERN_TESTS; i++) {
-            assertFalse(str1Interned == str2.intern());
+            assertNotSame(str1Interned, str2.intern());
         }
         timer.done();