source: osm/applications/editors/josm/plugins/reltoolbox/src/relcontext/relationfix/AssociatedStreetFixer.java@ 28693

Last change on this file since 28693 was 28693, checked in by larry0ua, 13 years ago

'RelToolbox: refactored relation fixing code, added associatedStreet as a fixable relation'

File size: 4.6 KB
Line 
1package relcontext.relationfix;
2
3import java.util.ArrayList;
4import java.util.HashMap;
5import java.util.List;
6import java.util.Map;
7
8import org.openstreetmap.josm.command.ChangeCommand;
9import org.openstreetmap.josm.command.Command;
10import org.openstreetmap.josm.command.SequenceCommand;
11import org.openstreetmap.josm.data.osm.Node;
12import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
13import org.openstreetmap.josm.data.osm.Relation;
14import org.openstreetmap.josm.data.osm.RelationMember;
15import org.openstreetmap.josm.data.osm.Way;
16
17import static org.openstreetmap.josm.tools.I18n.tr;
18
19public class AssociatedStreetFixer extends RelationFixer {
20
21 public AssociatedStreetFixer() {
22 super("associatedStreet");
23 }
24
25 @Override
26 public boolean isRelationGood(Relation rel) {
27 for (RelationMember m : rel.getMembers()) {
28 if (m.getType().equals(OsmPrimitiveType.NODE) && !"house".equals(m.getRole()))
29 return false;
30 if (m.getType().equals(OsmPrimitiveType.WAY) && !("house".equals(m.getRole()) || "street".equals(m.getRole())))
31 return false;
32 if (m.getType().equals(OsmPrimitiveType.RELATION) && !"house".equals(m.getRole()))
33 return false;
34 }
35 // relation should have name
36 if (!rel.hasKey("name")) {
37 return false;
38 }
39 // check that all street members have same name as relation (???)
40 String streetName = rel.get("name");
41 for (RelationMember m : rel.getMembers()) {
42 if (m.getRole().equals("street") && !m.getWay().get("name").equals(streetName))
43 return false;
44 }
45 return true;
46 }
47
48 @Override
49 public Command fixRelation(Relation source) {
50 // any way with highway tag -> street
51 // any way/point/relation with addr:housenumber=* or building=* or type=multipolygon -> house
52 // name - check which name is most used in street members and add to relation
53 // copy this name to the other street members (???)
54 Relation rel = new Relation(source);
55 boolean fixed = false;
56
57 for (int i = 0; i < rel.getMembersCount(); i++) {
58 RelationMember m = rel.getMember(i);
59
60 if (m.isNode()) {
61 Node node = m.getNode();
62 if (!"house".equals(m.getRole()) &&
63 (node.hasKey("building") || node.hasKey("addr:housenumber"))) {
64 fixed = true;
65 rel.setMember(i, new RelationMember("house", node));
66 }
67 } else if (m.isWay()) {
68 Way way = m.getWay();
69 if (!"street".equals(m.getRole()) && way.hasKey("highway")) {
70 fixed = true;
71 rel.setMember(i, new RelationMember("street", way));
72 } else if (!"house".equals(m.getRole()) &&
73 (way.hasKey("building") || way.hasKey("addr:housenumber"))) {
74 fixed = true;
75 rel.setMember(i, new RelationMember("house", way));
76 }
77 } else if (m.isRelation()) {
78 Relation relation = m.getRelation();
79 if (!"house".equals(m.getRole()) &&
80 (relation.hasKey("building") || relation.hasKey("addr:housenumber") || "multipolygon".equals(relation.get("type")))) {
81 fixed = true;
82 rel.setMember(i, new RelationMember("house", relation));
83 }
84 }
85 }
86
87 // fill relation name
88 Map<String, Integer> streetNames = new HashMap<String, Integer>();
89 for (RelationMember m : rel.getMembers())
90 if ("street".equals(m.getRole()) && m.isWay()) {
91 String name = m.getWay().get("name");
92 if (name == null || name.isEmpty()) continue;
93
94 Integer count = streetNames.get(name);
95
96 streetNames.put(name, count != null? count + 1 : 1);
97 }
98 String commonName = "";
99 Integer commonCount = 0;
100 for (Map.Entry<String, Integer> entry : streetNames.entrySet()) {
101 if (entry.getValue() > commonCount) {
102 commonCount = entry.getValue();
103 commonName = entry.getKey();
104 }
105 }
106
107 if (!rel.hasKey("name")) {
108 fixed = true;
109 rel.put("name", commonName);
110 } else {
111 commonName = ""; // set empty common name - if we already have name on relation, do not overwrite it
112 }
113
114 List<Command> commandList = new ArrayList<Command>();
115 if (fixed) {
116 commandList.add(new ChangeCommand(source, rel));
117 }
118
119 /*if (!commonName.isEmpty())
120 // fill common name to streets
121 for (RelationMember m : rel.getMembers())
122 if ("street".equals(m.getRole()) && m.isWay()) {
123 String name = m.getWay().get("name");
124 if (commonName.equals(name)) continue;
125
126 // TODO: ask user if he really wants to overwrite street name??
127
128 Way oldWay = m.getWay();
129 Way newWay = new Way(oldWay);
130 newWay.put("name", commonName);
131
132 commandList.add(new ChangeCommand(oldWay, newWay));
133 }
134 */
135 // return results
136 if (commandList.size() == 0)
137 return null;
138 if (commandList.size() == 1)
139 return commandList.get(0);
140 return new SequenceCommand(tr("fix associatedStreet relation"), commandList);
141 }
142}
Note: See TracBrowser for help on using the repository browser.