Ticket #6953: SidetoolbarLayerChange.patch

src/org/openstreetmap/josm/gui/IconToggleButton.java

@@ -65 +65 @@
         }
     }
     
+    String getPreferenceKey() {
+        String s = (String) getSafeActionValue("toolbar");
+        if (s==null) {
+            if (getAction()!=null) s=getAction().getClass().getName();
+        }
+        return "sidetoolbar.hidden."+s;
+        
+    }
+    
     @Override
     public void applyButtonHiddenPreferences() {
-        String actionName = (String) getSafeActionValue(AbstractAction.NAME);
-        boolean hiddenFlag = Main.pref.getBoolean(actionName + ".itbutton_hidden", false);
+        boolean hiddenFlag = Main.pref.getBoolean(getPreferenceKey(), false);
         setVisible(!hiddenFlag);   
     }
 
     @Override
     public void setButtonHidden(boolean b) {
-        String actionName = (String) getSafeActionValue(AbstractAction.NAME);
         setVisible(!b);
         if (listener!=null) { // if someone wants to know about changes of visibility
             if (!b) listener.buttonShown(); else listener.buttonHidden();
         }
-        Main.pref.put(actionName + ".itbutton_hidden", b);
+        Main.pref.put(getPreferenceKey(), b);
     }
     
     @Override

src/org/openstreetmap/josm/gui/MapFrame.java

@@ -407 +407 @@
             }
         }));
     }
-   
+
         class ListAllButtonsAction extends AbstractAction {
 
         private JButton button;
@@ -453 +453 @@
         }
         toolBarToggle.repaint();
         for (IconToggleButton b : allMapModeButtons) {
-            b.applyButtonHiddenPreferences();
+            Action a=b.getAction();
+            boolean hideAnyway=false;
+            if (a instanceof MapMode) {
+                hideAnyway = !((MapMode)a).layerIsSupported(Main.main.getActiveLayer());
+            }
+            if (hideAnyway) b.setVisible(false); else  
+                b.applyButtonHiddenPreferences();
         }
         toolBarActions.repaint();
     }
-
+    
     /**
      * Replies the instance of a toggle dialog of type <code>type</code> managed by this
      * map frame
@@ -532 +538 @@
             mapMode.exitMode();
             mapMode.enterMode();
         }
+        validateToolBarsVisibility();
         // invalidate repaint cache
         Main.map.mapView.preferenceChanged(null);
     }