Ticket #20598: 20598.2.patch

src/org/openstreetmap/josm/data/ImageData.java

@@ -59 +59 @@
         if (data != null) {
             Collections.sort(data);
             this.data = data;
+            this.data.forEach(image -> image.setDataSet(this));
         } else {
             this.data = new ArrayList<>();
         }
         this.geoImages.addAll(this.data);
-        data.forEach(image -> image.setDataSet(this));
         selectedImagesIndex.add(-1);
     }
 

src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java

@@ -240 +240 @@
                     }
                     curTmp.setGpsTime(new Date(curImg.getExifTime().getTime() - offset));
                     curTmp.flagNewGpsData();
+                    curImg.tmpUpdated();
+
                     ret++;
                 }
                 i--;
@@ -264 +266 @@
                     }
                     curTmp.setGpsTime(new Date(curImg.getExifTime().getTime() - offset));
                     curTmp.flagNewGpsData();
+                    curImg.tmpUpdated();
 
                     ret++;
                 }

src/org/openstreetmap/josm/data/gpx/GpxImageEntry.java

@@ -508 +508 @@
             isNewGpsData = tmp.isNewGpsData;
             tmp = null;
         }
+        tmpUpdated();
     }
 
     /**
@@ -516 +517 @@
      */
     public void discardTmp() {
         tmp = null;
+        tmpUpdated();
     }
 
     /**
@@ -548 +550 @@
         isNewGpsData = true;
    }
 
+    /**
+     * Indicate that the temporary copy has been updated. Mostly used to prevent UI issues.
+     * By default, this is a no-op. Override when needed in subclasses.
+     * @since xxx
+     */
+    protected void tmpUpdated() {
+        // No-op by default
+    }
+
     @Override
     public BBox getBBox() {
         // new BBox(LatLon) is null safe.

src/org/openstreetmap/josm/gui/layer/geoimage/ImageEntry.java

@@ -32 +32 @@
     public ImageEntry(ImageEntry other) {
         super(other);
         thumbnail = other.thumbnail;
+        dataSet = other.dataSet;
     }
 
     /**
@@ -77 +78 @@
     }
 
     @Override
-    public void applyTmp() {
-        super.applyTmp();
+    protected void tmpUpdated() {
+        super.tmpUpdated();
         if (this.dataSet != null) {
             this.dataSet.fireNodeMoved(this);
         }
     }
 
-    @Override
-    public void discardTmp() {
-        super.discardTmp();
-        if (this.dataSet != null) {
-            this.dataSet.fireNodeMoved(this);
-        }
-    }
-
     /**
      * Set the dataset for this image
      * @param imageData The dataset
@@ -122 +115 @@
         if (!super.equals(obj) || getClass() != obj.getClass())
             return false;
         ImageEntry other = (ImageEntry) obj;
-        return Objects.equals(thumbnail, other.thumbnail);
+        return Objects.equals(thumbnail, other.thumbnail) && Objects.equals(dataSet, other.dataSet);
     }
 }