Ticket #19142: 19142.patch

src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/IDatePicker.java

@@ -6 +6 @@
 
 import javax.swing.JComponent;
 
+import org.openstreetmap.josm.plugins.mapillary.utils.MapillaryProperties;
+import org.openstreetmap.josm.tools.Logging;
+
 /**
  * @author Taylor Smock
  */
@@ -19 +22 @@
   void reset();
 
   void addEventHandler(Consumer<IDatePicker<?>> function);
+
+  public static IDatePicker<? extends JComponent> getNewDatePicker() {
+    boolean fx = false;
+    boolean useFx = MapillaryProperties.JAVA_FX.get();
+    if (useFx) {
+      try {
+        new DatePickerFx();
+        fx = true;
+      } catch (UnsupportedClassVersionError e) {
+        Logging.error(e);
+      }
+    }
+    if (fx) {
+      return new DatePickerFx();
+    }
+    return new DatePickerSwing();
+  }
 }

src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryFilterDialog.java

@@ -50 +50 @@
 import org.openstreetmap.josm.plugins.mapillary.oauth.MapillaryUser;
 import org.openstreetmap.josm.tools.GBC;
 import org.openstreetmap.josm.tools.ImageProvider;
-import org.openstreetmap.josm.tools.Logging;
 
 /**
  * ToggleDialog that lets you filter the images that are being shown.
@@ -119 +118 @@
     fromPanel.add(this.time);
 
     JPanel timePanel;
-    try {
-      startDate = new DatePickerFx();
-      endDate = new DatePickerFx();
-    } catch (UnsupportedClassVersionError e) {
-      // Don't kill the plugin if JavaFX cannot be loaded
-      Logging.error(e);
-      startDate = new DatePickerSwing();
-      endDate = new DatePickerSwing();
-    }
+    startDate = IDatePicker.getNewDatePicker();
+    endDate = IDatePicker.getNewDatePicker();
     Consumer<IDatePicker<?>> function = this::updateDates;
     startDate.addEventHandler(function);
     endDate.addEventHandler(function);

src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryPreferenceSetting.java

@@ -101 +101 @@
   private final JLabel loginLabel = new JLabel();
   private final JPanel loginPanel = new JPanel();
 
+  private JCheckBox javaFx;
+
   @Override
   public TabPreferenceSetting getTabPreferenceSetting(PreferenceTabbedPane gui) {
     return gui.getDisplayPreference();
@@ -169 +171 @@
     requiresLogin.add(new JSeparator(), GBC.eol().fill(GBC.HORIZONTAL));
     mainPanel.add(requiresLogin, GBC.eol().fill(GBC.HORIZONTAL));
 
+    javaFx = new JCheckBox(I18n.tr("Use JavaFX for better looking dialogs"));
+    javaFx.setToolTipText(I18n.tr("Enable/disable JavaFX (requires restart). Using JavaFX may cause a smaller window issue, or a whited-out sidebar."));
+    javaFx.setSelected(MapillaryProperties.JAVA_FX.get());
+    mainPanel.add(new JSeparator(), GBC.eol().fill(GBC.HORIZONTAL));
+    mainPanel.add(javaFx, GBC.eol());
+
     if (ExpertToggleAction.isExpert() || developer.isSelected()) {
       mainPanel.add(developer, GBC.eol());
     }
     MapillaryColorScheme.styleAsDefaultPanel(
       mainPanel, downloadModePanel, displayHour, format24, moveTo, hoverEnabled, darkMode, cutOffSeq,
-      imageLinkToBlurEditor, developer, preFetchPanel, requiresLogin
+      imageLinkToBlurEditor, developer, preFetchPanel, requiresLogin, javaFx
       );
     mainPanel.add(Box.createVerticalGlue(), GBC.eol().fill(GridBagConstraints.BOTH));
 
@@ -236 +244 @@
     MapillaryProperties.PRE_FETCH_IMAGE_COUNT.put(preFetchSize.getNumber().intValue());
     MapillaryProperties.IMAGE_MODE.put(((PRIVATE_IMAGE_DOWNLOAD_MODE) privateImages.getSelectedItem()).getPrefId());
 
-    //Restart is never required
-    return false;
+    //Restart is never required, except when JavaFX is switched on/off
+    return MapillaryProperties.JAVA_FX.put(javaFx.isSelected());
   }
 
   @Override

src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/dialog/MapillaryExpertFilterDialog.java

@@ -519 +519 @@
       }
     }
   }
-}
- No newline at end of file
+}

src/main/java/org/openstreetmap/josm/plugins/mapillary/gui/dialog/TrafficSignFilter.java

@@ -39 +39 @@
 import org.openstreetmap.josm.data.osm.Filter;
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.widgets.FilterField;
-import org.openstreetmap.josm.plugins.mapillary.gui.DatePickerFx;
-import org.openstreetmap.josm.plugins.mapillary.gui.DatePickerSwing;
 import org.openstreetmap.josm.plugins.mapillary.gui.IDatePicker;
 import org.openstreetmap.josm.plugins.mapillary.gui.ImageCheckBoxButton;
 import org.openstreetmap.josm.tools.Destroyable;
@@ -194 +192 @@
       lastSeen.add(new JLabel(I18n.tr("Last Seen End")), GBC.eol());
     }
 
-    boolean fx = false;
-    try {
-      new DatePickerFx();
-      fx = true;
-    } catch (UnsupportedClassVersionError e) {
-      Logging.error(e);
-    }
-    final IDatePicker<?> firstSeenPicker;
-    final IDatePicker<?> lastSeenPicker;
-    if (fx) {
-      firstSeenPicker = new DatePickerFx();
-      lastSeenPicker = new DatePickerFx();
-    } else {
-      firstSeenPicker = new DatePickerSwing();
-      lastSeenPicker = new DatePickerSwing();
-    }
+    final IDatePicker<?> firstSeenPicker = IDatePicker.getNewDatePicker();
+    final IDatePicker<?> lastSeenPicker = IDatePicker.getNewDatePicker();
     firstSeen.add(firstSeenPicker.getComponent(), GBC.eol());
     lastSeen.add(lastSeenPicker.getComponent(), GBC.eol());
     firstSeenPicker.addEventHandler(t -> updateDates(firstLast, firstSeenPicker, firstSeenPicker, lastSeenPicker));

src/main/java/org/openstreetmap/josm/plugins/mapillary/utils/MapillaryProperties.java

@@ -87 +87 @@
    */
   public static final DoubleProperty UNSELECTED_OPACITY = new DoubleProperty("mapillary.unselectedimageopacity", 0.50);
 
+  /**
+   * Whether or not to try to use JavaFX
+   */
+  public static final BooleanProperty JAVA_FX = new BooleanProperty("mapillary.javafx", true);
+
   private MapillaryProperties() {
     // Private constructor to avoid instantiation
   }